cli: Add --disable-update-check flag

Closes #2361

Author: nhooyr

ci/dev/vscode.patch

@@ -769,10 +769,10 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894
  	remove(key: string, scope: StorageScope): void {
 diff --git a/src/vs/server/browser/client.ts b/src/vs/server/browser/client.ts
 new file mode 100644
-index 0000000000000000000000000000000000000000..71df1d2b0a718c6a6fbb66a075be52d1be3ff00d
+index 0000000000000000000000000000000000000000..bae5b43e07e33b24ed5cc62d39c6b929c0bc4e5f
 --- /dev/null
 +++ b/src/vs/server/browser/client.ts
-@@ -0,0 +1,239 @@
+@@ -0,0 +1,241 @@
 +import { Emitter } from 'vs/base/common/event';
 +import { URI } from 'vs/base/common/uri';
 +import { localize } from 'vs/nls';
@@ -926,7 +926,7 @@ index 0000000000000000000000000000000000000000..71df1d2b0a718c6a6fbb66a075be52d1
 +
 +	const logService = (services.get(ILogService) as ILogService);
 +	const storageService = (services.get(IStorageService) as IStorageService);
-+	const updateCheckEndpoint = path.join(options.base, "/update/check")
++	const updateCheckEndpoint = path.join(options.base, "/update/check");
 +	const getUpdate = async (): Promise<void> => {
 +		logService.debug("Checking for update...");
 +
@@ -946,8 +946,8 @@ index 0000000000000000000000000000000000000000..71df1d2b0a718c6a6fbb66a075be52d1
 +
 +		const lastNoti = storageService.getNumber("csLastUpdateNotification", StorageScope.GLOBAL);
 +		if (lastNoti) {
-+			// Only remind them again after two days.
-+			const timeout = 1000*60*24*2;
++			// Only remind them again after 1 week.
++			const timeout = 1000*60*24*7;
 +			const threshold = lastNoti + timeout;
 +			if (Date.now() < threshold) {
 +				return;
@@ -970,7 +970,9 @@ index 0000000000000000000000000000000000000000..71df1d2b0a718c6a6fbb66a075be52d1
 +		});
 +	};
 +
-+	updateLoop();
++	if (!options.disableUpdateCheck) {
++		updateLoop();
++	}
 +
 +	// This will be used to set the background color while VS Code loads.
 +	const theme = storageService.get("colorThemeData", StorageScope.GLOBAL);
@@ -1404,17 +1406,18 @@ index 0000000000000000000000000000000000000000..56331ff1fc32bbd82e769aaecb551e42
 +require('../../bootstrap-amd').load('vs/server/entry');
 diff --git a/src/vs/server/ipc.d.ts b/src/vs/server/ipc.d.ts
 new file mode 100644
-index 0000000000000000000000000000000000000000..fd0115a74eb2d7362a3bf2543cb354a29a58936a
+index 0000000000000000000000000000000000000000..14f658f2702034a0500aebb5417576e5d6ffe406
 --- /dev/null
 +++ b/src/vs/server/ipc.d.ts
-@@ -0,0 +1,132 @@
+@@ -0,0 +1,133 @@
 +/**
 + * External interfaces for integration into code-server over IPC. No vs imports
 + * should be made in this file.
 + */
 +export interface Options {
-+	disableTelemetry: boolean
 +	base: string
++	disableTelemetry: boolean
++	disableUpdateCheck: boolean
 +}
 +
 +export interface InitMessage {

src/node/cli.ts

@@ -33,6 +33,7 @@ export interface Args extends VsArgs {
   "cert-host"?: string
   "cert-key"?: string
   "disable-telemetry"?: boolean
+  "disable-update-check"?: boolean
   help?: boolean
   host?: string
   json?: boolean
@@ -114,6 +115,12 @@ const options: Options<Required<Args>> = {
   },
   "cert-key": { type: "string", path: true, description: "Path to certificate key when using non-generated cert." },
   "disable-telemetry": { type: "boolean", description: "Disable telemetry." },
+  "disable-update-check": {
+    type: "boolean",
+    description:
+      "Disable update check. Without this flag, code-server checks every 6 hours against the latest github release and \n" +
+      "then notifies you once every week that a new release is available.",
+  },
   help: { type: "boolean", short: "h", description: "Show this output." },
   json: { type: "boolean" },
   open: { type: "boolean", description: "Open in browser on startup. Does not work remotely." },

src/node/routes/vscode.ts

@@ -42,6 +42,7 @@ router.get("/", async (req, res) => {
       commit !== "development" ? content.replace(/<!-- PROD_ONLY/g, "").replace(/END_PROD_ONLY -->/g, "") : content,
       {
         disableTelemetry: !!req.args["disable-telemetry"],
+        disableUpdateCheck: !!req.args["disable-update-check"],
       },
     )
       .replace(`"{{REMOTE_USER_DATA_URI}}"`, `'${JSON.stringify(options.remoteUserDataUri)}'`)