fix(tea): do not force color profile if session is not a PTY #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only force the color profile if the requested session is a PTY. We also print warning messages to the client's stderr if we force a color profile. Fixes: charmbracelet/soft-serve#683
aymanbagabas
requested review from
a team,
bashbunni and
caarlos0
and removed request for
a team
raphamorim
approved these changes
Mar 25, 2025
caarlos0
reviewed
Mar 25, 2025
caarlos0
approved these changes
Mar 25, 2025
andreynering
approved these changes
Mar 25, 2025
Co-authored-by: Carlos Alexandro Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only force the color profile if the requested session is a PTY. We also print warning messages to the client's stderr if we force a color profile.
Fixes: charmbracelet/soft-serve#683