fix: [#1154] Removes global typescript definition that was used for custom elements (#1840)

* fix: [#1154] Removes global typescript definition that was used for custom elements to solve typescript compilation when skipLibCheck is set to false

* fix: [#1154] Removes global typescript definition that was used for custom elements to solve typescript compilation when skipLibCheck is set to false

Author: capricorn86

packages/happy-dom/src/config/IHTMLElementTagNameMap.ts

@@ -63,16 +63,7 @@ import HTMLTrackElement from '../nodes/html-track-element/HTMLTrackElement.js';
 import HTMLUListElement from '../nodes/html-u-list-element/HTMLUListElement.js';
 import HTMLVideoElement from '../nodes/html-video-element/HTMLVideoElement.js';
 
-// Makes it work with custom elements when they declare their own interface.
-declare global {
-	/* eslint-disable @typescript-eslint/naming-convention */
-	/* eslint-disable @typescript-eslint/no-empty-interface */
-	interface HTMLElementTagNameMap {}
-	/* eslint-enable @typescript-eslint/naming-convention */
-	/* eslint-enable @typescript-eslint/no-empty-interface */
-}
-
-export default interface IHTMLElementTagNameMap extends HTMLElementTagNameMap {
+export default interface IHTMLElementTagNameMap {
 	a: HTMLAnchorElement;
 	abbr: HTMLElement;
 	address: HTMLElement;

packages/happy-dom/src/event/IEventListenerOptions.ts

@@ -1,4 +1,4 @@
-import AbortSignal from 'src/fetch/AbortSignal.js';
+import AbortSignal from '../fetch/AbortSignal.js';
 
 export default interface IEventListenerOptions {
 	once?: boolean;

packages/happy-dom/src/nodes/html-media-element/HTMLMediaElement.ts

@@ -1,4 +1,3 @@
-import ErrorEvent from '../../event/events/ErrorEvent.js';
 import Event from '../../event/Event.js';
 import DOMExceptionNameEnum from '../../exception/DOMExceptionNameEnum.js';
 import HTMLElement from '../html-element/HTMLElement.js';
@@ -105,14 +104,6 @@ export default class HTMLMediaElement extends HTMLElement {
 		this[PropertySymbol.propertyEventListeners].set('onended', value);
 	}
 
-	public get onerror(): ((event: ErrorEvent) => void) | null {
-		return ElementEventAttributeUtility.getEventListener(this, 'onerror');
-	}
-
-	public set onerror(value: ((event: ErrorEvent) => void) | null) {
-		this[PropertySymbol.propertyEventListeners].set('onerror', value);
-	}
-
 	public get onloadeddata(): ((event: Event) => void) | null {
 		return ElementEventAttributeUtility.getEventListener(this, 'onloadeddata');
 	}

packages/happy-dom/src/nodes/node/ICachedComputedStyleResult.ts

@@ -2,5 +2,5 @@ import CSSStyleDeclarationPropertyManager from '../../css/declaration/property-m
 import ICachedResult from './ICachedResult.js';
 
 export default interface ICachedComputedStyleResult extends ICachedResult {
-	result: WeakRef<CSSStyleDeclarationPropertyManager | null> | null;
+	result: WeakRef<CSSStyleDeclarationPropertyManager> | null;
 }

packages/happy-dom/src/nodes/node/ICachedQuerySelectorResult.ts

@@ -2,5 +2,5 @@ import Element from '../element/Element.js';
 import ICachedResult from './ICachedResult.js';
 
 export default interface ICachedQuerySelectorResult extends ICachedResult {
-	result: WeakRef<Element | null> | null;
+	result: WeakRef<Element> | null;
 }

packages/happy-dom/src/nodes/node/ICachedStyleResult.ts

@@ -2,5 +2,5 @@ import CSSStyleDeclarationPropertyManager from '../../css/declaration/property-m
 import ICachedResult from './ICachedResult.js';
 
 export default interface ICachedStyleResult extends ICachedResult {
-	result: WeakRef<CSSStyleDeclarationPropertyManager | null> | null;
+	result: WeakRef<CSSStyleDeclarationPropertyManager> | null;
 }

packages/happy-dom/src/query-selector/QuerySelector.ts

@@ -237,7 +237,7 @@ export default class QuerySelector {
 		}
 
 		const cachedItem: ICachedQuerySelectorItem = {
-			result: <WeakRef<Element | null>>{
+			result: <WeakRef<Element>>{
 				deref: () => null
 			}
 		};

packages/happy-dom/tsconfig.json

@@ -13,8 +13,10 @@
 		"resolveJsonModule": true,
 		"noUnusedLocals": true,
 		"noUnusedParameters": true,
+        "noImplicitReturns": false,
 		"removeComments": false,
 		"preserveConstEnums": true,
+        "strict": false,
 		"sourceMap": true,
 		"skipLibCheck": true,
 		"baseUrl": ".",