-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
sd and sdgram networks for systemd.socket named file descriptors #7331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @Siomachkin |
| // type is standard, reserved, or already registered. | ||
| // | ||
| // EXPERIMENTAL: Subject to change. | ||
| func RegisterNetworkHTTP3(originalNetwork, h3Network string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this will be a breaking change to https://sourcegraph.com/github.com/tailscale/caddy-tailscale/-/blob/module.go?L36-39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave this in and have this call caddy.RegisterNetworkHTTP3 to keep backwards compat for a while, and mark this as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah that works, I'll put it back.
|
drafted to evaluate a |
|
How does the I don't see a problem with leaving that code compiled in for all linux builds because it requires a pretty specific combination of env vars to be set to work anyway, and throws an error that the user needs to handle otherwise. |
yes, it is a tag. the best reason I can give for the target is that it smells to test this feature on osx and windows. using a negated target leaves it on by default. that said, closed in favor of #7340 |
|
Well the |
Assistance Disclosure
No AI was used.
Implements #7243 with https://github.com/MayCXC/caddy-systemd-socket-activation to read
LISTEN_FDSandLISTEN_PIDfrom the environment as well, support binding port ranges to homonymous file descriptors, and reserve the datagram networks for h3.Caddyfile syntax comparison:
bind fdname/name:10->bind sd/name/10bind fdgramname/name:10->bind sdgram/name/10Support for both is moved to the
linux && !nosystemdtarget, and custom network support code is isolated innetworks.go. This is also a nice way to implementifacecustom networks for #7256