correct how dist is ignored in .gitignore #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
approved these changes
Jan 15, 2019
Member
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
I checked https://github.com/canjs/can-single-reference for… reference because it publishes the dist folder, and this change seems to make FuncUnit match that repo. I’d still double check that the dist folder gets published after merging & releasing this though. 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #232
Changes:
Correct how
distfolder is ignored in.gitignorefrom justdisttodist/so it will be the same as in.npmignore, like this npm will take the configuration of.npmignore