Update CSM tests to treat warnings as errors

dscpinheiro · web-flow · commit 2b3f677f9140 · 2025-12-09T21:39:54.000-05:00
diff --git a/sdk/test/CSMTest/Tests/IntegrationTests/AWSSDK.CSM.IntegrationTests.NetFramework.csproj b/sdk/test/CSMTest/Tests/IntegrationTests/AWSSDK.CSM.IntegrationTests.NetFramework.csproj
@@ -17,6 +17,7 @@
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
     <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
     <NoWarn>CS1591</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/sdk/test/CSMTest/Tests/IntegrationTests/AWSSDK.CSM.IntegrationTests.NetStandard.csproj b/sdk/test/CSMTest/Tests/IntegrationTests/AWSSDK.CSM.IntegrationTests.NetStandard.csproj
@@ -16,7 +16,8 @@
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
 
-    <NoWarn>CS1591</NoWarn>
+    <NoWarn>CS1591,NU1701</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -35,11 +36,5 @@
   <ItemGroup>
     <ProjectReference Include="../../../../src/Core/AWSSDK.Core.NetStandard.csproj" />
     <ProjectReference Include="../../../../src/Services/DynamoDBv2/AWSSDK.DynamoDBv2.NetStandard.csproj" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <Reference Include="System.Configuration" />
-    <Reference Include="System.Net.Http" />
-  </ItemGroup>
-  
+  </ItemGroup>  
 </Project>
diff --git a/sdk/test/CSMTest/Tests/IntegrationTests/CSMTestUtilities.cs b/sdk/test/CSMTest/Tests/IntegrationTests/CSMTestUtilities.cs
@@ -100,7 +100,7 @@ public void Validate(IList<string> stash)
                     {
                         Validate(JsonConvert.DeserializeObject<MonitoringAPICallEvent>(value));
                     }
-                    catch (Exception e)
+                    catch
                     {
                         Validate(JsonConvert.DeserializeObject<MonitoringAPICallAttempt>(value));
                     }
diff --git a/sdk/test/CSMTest/Tests/IntegrationTests/_bcl/PerfTests/CSMPerfTestsAsync.cs b/sdk/test/CSMTest/Tests/IntegrationTests/_bcl/PerfTests/CSMPerfTestsAsync.cs
@@ -80,7 +80,7 @@ public async Task MultipleSuccessfulRequestsTestAsync()
                     {
                         testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallEvent>(value));
                     }
-                    catch (Exception e)
+                    catch
                     {
                         testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallAttempt>(value));
                     }
diff --git a/sdk/test/CSMTest/Tests/IntegrationTests/_bcl/PerfTests/CSMPerfTestsSync.cs b/sdk/test/CSMTest/Tests/IntegrationTests/_bcl/PerfTests/CSMPerfTestsSync.cs
@@ -80,7 +80,7 @@ public void MultipleSuccessfulRequestsTest()
                     {
                         testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallEvent>(value));
                     }
-                    catch (Exception e)
+                    catch
                     {
                         testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallAttempt>(value));
                     }
diff --git a/sdk/test/CSMTest/Tests/UnitTests/CSMUtilitiesTests/AWSSDK.CSMUtilitiesTests.NetFramework/AWSSDK.CSMUtilitiesTests.NetFramework.csproj b/sdk/test/CSMTest/Tests/UnitTests/CSMUtilitiesTests/AWSSDK.CSMUtilitiesTests.NetFramework/AWSSDK.CSMUtilitiesTests.NetFramework.csproj
@@ -19,6 +19,7 @@
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
 
     <NoWarn>CS1591</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
 
diff --git a/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.AppConfigTests.NetFramework.csproj b/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.AppConfigTests.NetFramework.csproj
@@ -17,6 +17,7 @@
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
 
     <NoWarn>CS1591</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -46,12 +47,7 @@
     <Reference Include="System.Configuration" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
-
   <ItemGroup>
     <None Include="App.config" />
   </ItemGroup>
-
 </Project>
diff --git a/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.EnvFallBackTests.NetFramework.csproj b/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.EnvFallBackTests.NetFramework.csproj
@@ -17,6 +17,7 @@
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
 
     <NoWarn>CS1591</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -47,9 +48,4 @@
   <ItemGroup>
     <Reference Include="System.Configuration" />
   </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
-
 </Project>
diff --git a/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.EnvFallBackTests.NetStandard.csproj b/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.EnvFallBackTests.NetStandard.csproj
@@ -15,7 +15,8 @@
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
 
-    <NoWarn>CS1591</NoWarn>
+    <NoWarn>CS1591,NU1701</NoWarn>
+	<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -42,13 +43,4 @@
   <ItemGroup>
     <ProjectReference Include="..\..\..\..\..\src\Core\AWSSDK.Core.NetStandard.csproj" />
   </ItemGroup>
-
-  <ItemGroup>
-    <Reference Include="System.Configuration" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
-
 </Project>
diff --git a/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.SharedProfileTests.NetFramework.csproj b/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.SharedProfileTests.NetFramework.csproj
@@ -17,6 +17,7 @@
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
 
     <NoWarn>CS1591</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -44,9 +45,4 @@
   <ItemGroup>
     <Reference Include="System.Configuration" />
   </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
-
 </Project>
diff --git a/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.SharedProfileTests.NetStandard.csproj b/sdk/test/CSMTest/Tests/UnitTests/FallBackConfigTests/AWSSDK.SharedProfileTests.NetStandard.csproj
@@ -15,8 +15,9 @@
     <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
-    
-    <NoWarn>CS1591</NoWarn>
+
+    <NoWarn>CS1591,NU1701</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -37,13 +38,4 @@
   <ItemGroup>
     <ProjectReference Include="..\..\..\..\..\src\Core\AWSSDK.Core.NetStandard.csproj" />
   </ItemGroup>
-
-  <ItemGroup>
-    <Reference Include="System.Configuration" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
-
 </Project>

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public void Validate(IList<string> stash)`
`100`	`100`	`{`
`101`	`101`	`Validate(JsonConvert.DeserializeObject<MonitoringAPICallEvent>(value));`
`102`	`102`	`}`
`103`		`- catch (Exception e)`
	`103`	`+ catch`
`104`	`104`	`{`
`105`	`105`	`Validate(JsonConvert.DeserializeObject<MonitoringAPICallAttempt>(value));`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public async Task MultipleSuccessfulRequestsTestAsync()`
`80`	`80`	`{`
`81`	`81`	`testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallEvent>(value));`
`82`	`82`	`}`
`83`		`- catch (Exception e)`
	`83`	`+ catch`
`84`	`84`	`{`
`85`	`85`	`testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallAttempt>(value));`
`86`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public void MultipleSuccessfulRequestsTest()`
`80`	`80`	`{`
`81`	`81`	`testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallEvent>(value));`
`82`	`82`	`}`
`83`		`- catch (Exception e)`
	`83`	`+ catch`
`84`	`84`	`{`
`85`	`85`	`testUtils.Validate(JsonConvert.DeserializeObject<MonitoringAPICallAttempt>(value));`
`86`	`86`	`}`