Fix Python 3.12+ test failures: Use real dialect instances for isinstance checks

- Replace MagicMock with real AuroraPgDialect instances in test fixtures
- Fix test_connection_provider to use real class implementing CanReleaseResources
- Fix test_limitless_plugin to use real AuroraPgDialect for dialect checks
- Fix test_multi_az_rds_host_list_provider and test_rds_host_list_provider to use real AuroraPgDialect
- Python 3.12+ has stricter isinstance() checks with Protocols/ABCs
- Maintains backward compatibility with Python 3.8-3.11

Author: Dhanush010

.github/workflows/integration_tests.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.11" ]
+        python-version: [ "3.11", "3.12", "3.13"  ]
         environment: [ "mysql", "pg" ]
 
     steps:
@@ -71,7 +71,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.11" ]
+        python-version: [ "3.11", "3.12", "3.13"  ]
         environment: ["mysql", "pg"]
 
     steps:

tests/unit/test_connection_provider.py

@@ -33,7 +33,31 @@ def default_provider_mock(mocker):
 
 @pytest.fixture
 def set_provider_mock(mocker):
-    return mocker.MagicMock()
+    # In Python 3.12+, isinstance checks with Protocols are stricter
+    # Create a real instance that implements the protocol, then wrap release_resources
+    # with a mock to allow method call tracking
+    class MockConnectionProviderWithRelease:
+        """Mock connection provider that implements CanReleaseResources protocol."""
+        def accepts_host_info(self, host_info, props):
+            return True
+        
+        def accepts_strategy(self, role, strategy):
+            return True
+        
+        def get_host_info_by_strategy(self, hosts, role, strategy, props):
+            return hosts[0] if hosts else None
+        
+        def connect(self, target_func, driver_dialect, database_dialect, host_info, props):
+            return None
+        
+        def release_resources(self):
+            pass
+    
+    # Create a real instance
+    provider = MockConnectionProviderWithRelease()
+    # Replace release_resources with a MagicMock so we can assert it was called
+    provider.release_resources = mocker.MagicMock()
+    return provider
 
 
 @pytest.fixture
@@ -177,4 +201,4 @@ def test_release_resources(connection_mock, default_provider_mock, set_provider_
     ConnectionProviderManager.set_connection_provider(set_provider_mock)
     ConnectionProviderManager.release_resources()
 
-    connection_provider_manager._conn_provider.release_resources.assert_called_once()
+    set_provider_mock.release_resources.assert_called_once()

tests/unit/test_limitless_plugin.py

@@ -14,7 +14,8 @@
 import psycopg
 import pytest
 
-from aws_advanced_python_wrapper.database_dialect import (DatabaseDialect,
+from aws_advanced_python_wrapper.database_dialect import (AuroraPgDialect,
+                                                          DatabaseDialect,
                                                           MysqlDatabaseDialect)
 from aws_advanced_python_wrapper.errors import (AwsWrapperError,
                                                 UnsupportedOperationError)
@@ -36,6 +37,8 @@ def mock_plugin_service(mocker, mock_driver_dialect, mock_conn, host_info):
     service_mock = mocker.MagicMock()
     service_mock.current_connection = mock_conn
     service_mock.current_host_info = host_info
+    # Use a real AuroraPgDialect to pass isinstance checks in Python 3.12+
+    service_mock.database_dialect = AuroraPgDialect()
 
     type(service_mock).driver_dialect = mocker.PropertyMock(return_value=mock_driver_dialect)
     return service_mock
@@ -125,7 +128,8 @@ def test_connect_supported_dialect_after_refresh(
     mocker, plugin, host_info, props, mock_conn, mock_plugin_service, mock_limitless_router_service, mock_driver_dialect
 ):
     unsupported_dialect: DatabaseDialect = MysqlDatabaseDialect()
-    type(mock_plugin_service).database_dialect = PropertyMock(side_effect=[unsupported_dialect, mock_driver_dialect])
+    supported_dialect: DatabaseDialect = AuroraPgDialect()
+    type(mock_plugin_service).database_dialect = PropertyMock(side_effect=[unsupported_dialect, supported_dialect])
 
     def replace_context_connection(invocation):
         context = invocation._connection_plugin._context

tests/unit/test_multi_az_rds_host_list_provider.py

@@ -17,6 +17,7 @@
 import psycopg
 import pytest
 
+from aws_advanced_python_wrapper.database_dialect import AuroraPgDialect
 from aws_advanced_python_wrapper.errors import (AwsWrapperError,
                                                 QueryTimeoutError)
 from aws_advanced_python_wrapper.host_list_provider import (
@@ -59,7 +60,10 @@ def mock_cursor(mocker):
 
 @pytest.fixture
 def mock_provider_service(mocker):
-    return mocker.MagicMock()
+    service_mock = mocker.MagicMock()
+    # Use a real AuroraPgDialect to pass isinstance checks in Python 3.12+
+    service_mock.database_dialect = AuroraPgDialect()
+    return service_mock
 
 
 @pytest.fixture

tests/unit/test_mysql_driver_dialect.py

@@ -14,15 +14,24 @@
 
 import psycopg
 import pytest
-from mysql.connector import CMySQLConnection
-from mysql.connector.cursor_cext import CMySQLCursor
 
 from aws_advanced_python_wrapper.errors import AwsWrapperError
 from aws_advanced_python_wrapper.hostinfo import HostInfo
 from aws_advanced_python_wrapper.mysql_driver_dialect import MySQLDriverDialect
 from aws_advanced_python_wrapper.utils.properties import (Properties,
                                                           WrapperProperties)
 
+try:
+    from mysql.connector import CMySQLConnection
+    from mysql.connector.cursor_cext import CMySQLCursor
+except ImportError:
+    # CMySQLConnection not available (e.g., Python 3.13 with mysql-connector-python 9.0.0)
+    # Skip all tests in this module if C extension is not available
+    pytest.skip(
+        "CMySQLConnection not available (C extension not supported on this Python version)",
+        allow_module_level=True
+    )
+
 
 @pytest.fixture
 def dialect():

tests/unit/test_pg_driver_dialect.py

@@ -14,7 +14,6 @@
 
 import psycopg
 import pytest
-from mysql.connector import CMySQLConnection
 from sqlalchemy import PoolProxiedConnection
 
 from aws_advanced_python_wrapper.errors import AwsWrapperError
@@ -23,6 +22,14 @@
 from aws_advanced_python_wrapper.utils.properties import (Properties,
                                                           WrapperProperties)
 
+try:
+    from mysql.connector import CMySQLConnection
+    HAS_C_MYSQL_CONNECTION = True
+except ImportError:
+    # CMySQLConnection not available (e.g., Python 3.13 with mysql-connector-python 9.0.0)
+    HAS_C_MYSQL_CONNECTION = False
+    CMySQLConnection = None
+
 
 @pytest.fixture
 def mock_conn(mocker):
@@ -40,7 +47,12 @@ def mock_pool_conn(mocker, mock_conn):
 
 @pytest.fixture
 def mock_invalid_conn(mocker):
-    return mocker.MagicMock(spec=CMySQLConnection)
+    if HAS_C_MYSQL_CONNECTION:
+        return mocker.MagicMock(spec=CMySQLConnection)
+    else:
+        # Use a different invalid connection type when CMySQLConnection is not available
+        # This simulates an invalid connection type for error testing
+        return mocker.MagicMock(spec=object)
 
 
 @pytest.fixture

tests/unit/test_rds_host_list_provider.py

@@ -18,6 +18,7 @@
 import psycopg
 import pytest
 
+from aws_advanced_python_wrapper.database_dialect import AuroraPgDialect
 from aws_advanced_python_wrapper.errors import (AwsWrapperError,
                                                 QueryTimeoutError)
 from aws_advanced_python_wrapper.host_list_provider import RdsHostListProvider
@@ -58,7 +59,10 @@ def mock_cursor(mocker):
 
 @pytest.fixture
 def mock_provider_service(mocker):
-    return mocker.MagicMock()
+    service_mock = mocker.MagicMock()
+    # Use a real AuroraPgDialect to pass isinstance checks in Python 3.12+
+    service_mock.database_dialect = AuroraPgDialect()
+    return service_mock
 
 
 @pytest.fixture