chore(maintenance): enable isolatedModules and isolate cache (#1765)

* chore(layers) widen version check in e2e

* chore(maintenance): enable isolatedModules

* chore: remove redundant comments from tsconfig

* chore: changed path of tsbuild cache

Author: dreamorosi

.gitignore

@@ -49,5 +49,4 @@ site
 tmp
 
 # TS build files
-tsconfig.tsbuildinfo
-tsconfig.esm.tsbuildinfo
+*.tsbuildinfo

layers/tests/e2e/layerPublisher.class.test.functionCode.ts

@@ -81,11 +81,22 @@ const getVersionFromModule = async (moduleName: string): Promise<string> => {
 
 export const handler = async (): Promise<void> => {
   // Check that the packages version matches the expected one
-  for (const moduleName of ['commons', 'logger', 'metrics', 'tracer']) {
+  for (const moduleName of [
+    'commons',
+    'logger',
+    'metrics',
+    'tracer',
+    'parameters',
+    'idempotency',
+    'batch',
+  ]) {
     const moduleVersion = await getVersionFromModule(moduleName);
-    if (moduleVersion != expectedVersion) {
+    // TODO: remove this check once v2 becomes GA
+    // if (moduleVersion != expectedVersion) {
+    if (!moduleVersion.startsWith(expectedVersion)) {
       throw new Error(
-        `Package version mismatch (${moduleName}): ${moduleVersion} != ${expectedVersion}`
+        // `Package version mismatch (${moduleName}): ${moduleVersion} != ${expectedVersion}`
+        `Package version mismatch (${moduleName}): ${moduleVersion} does not start with ${expectedVersion}`
       );
     }
   }

packages/batch/package.json

@@ -17,13 +17,12 @@
     "test:e2e:nodejs18x": "echo 'Not Implemented'",
     "test:e2e": "echo 'Not Implemented'",
     "watch": "jest --watch",
-    "build:cjs": "tsc --build --force && echo '{ \"type\": \"commonjs\" }' > lib/cjs/package.json",
-    "build:esm": "tsc --project tsconfig.esm.json && echo '{ \"type\": \"module\" }' > lib/esm/package.json",
+    "build:cjs": "tsc --build tsconfig.json && echo '{ \"type\": \"commonjs\" }' > lib/cjs/package.json",
+    "build:esm": "tsc --build tsconfig.esm.json && echo '{ \"type\": \"module\" }' > lib/esm/package.json",
     "build": "npm run build:esm & npm run build:cjs",
     "lint": "eslint --ext .ts,.js --no-error-on-unmatched-pattern .",
     "lint-fix": "eslint --fix --ext .ts,.js --no-error-on-unmatched-pattern .",
-    "prebuild": "rimraf ./lib",
-    "prepack": "rimraf ./lib/*.tsbuildinfo && node ../../.github/scripts/release_patch_package_json.js ."
+    "prepack": "node ../../.github/scripts/release_patch_package_json.js ."
   },
   "lint-staged": {
     "*.{js,ts}": "npm run lint-fix"

packages/batch/tsconfig.esm.json

@@ -3,7 +3,8 @@
   "compilerOptions": {
     "baseUrl": ".",
     "outDir": "./lib/esm",
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "tsBuildInfoFile": ".tsbuildinfo/esm.json"
   },
   "include": [
     "./src/**/*"

packages/batch/tsconfig.json

@@ -3,6 +3,7 @@
     "compilerOptions": {
         "outDir": "./lib/cjs/",
         "rootDir": "./src",
+        "tsBuildInfoFile": ".tsbuildinfo/cjs.json"
     },
     "include": [
         "./src/**/*"

packages/commons/package.json

@@ -16,12 +16,12 @@
     "test:e2e": "echo 'Not Applicable'",
     "watch": "jest --watch",
     "generateVersionFile": "echo \"// this file is auto generated, do not modify\nexport const PT_VERSION = '$(jq -r '.version' package.json)';\" > src/version.ts",
-    "build:cjs": "tsc --build --force && echo '{ \"type\": \"commonjs\" }' > lib/cjs/package.json",
-    "build:esm": "tsc --project tsconfig.esm.json && echo '{ \"type\": \"module\" }' > lib/esm/package.json",
+    "build:cjs": "tsc --build tsconfig.json && echo '{ \"type\": \"commonjs\" }' > lib/cjs/package.json",
+    "build:esm": "tsc --build tsconfig.esm.json && echo '{ \"type\": \"module\" }' > lib/esm/package.json",
     "build": "npm run build:esm & npm run build:cjs",
     "lint": "eslint --ext .ts,.js --no-error-on-unmatched-pattern .",
     "lint-fix": "eslint --fix --ext .ts,.js --no-error-on-unmatched-pattern .",
-    "prepack": "rimraf ./lib/*.tsbuildinfo && node ../../.github/scripts/release_patch_package_json.js ."
+    "prepack": "node ../../.github/scripts/release_patch_package_json.js ."
   },
   "lint-staged": {
     "*.{js,ts}": "npm run lint-fix"

packages/commons/src/types/LambdaInterface.ts

@@ -1,12 +1,12 @@
 import type { Handler } from 'aws-lambda';
 
-export type SyncHandler<T extends Handler> = (
+type SyncHandler<T extends Handler> = (
   event: Parameters<T>[0],
   context: Parameters<T>[1],
   callback: Parameters<T>[2]
 ) => void;
 
-export type AsyncHandler<T extends Handler> = (
+type AsyncHandler<T extends Handler> = (
   event: Parameters<T>[0],
   context: Parameters<T>[1]
 ) => Promise<NonNullable<Parameters<Parameters<T>[2]>[1]>>;
@@ -23,4 +23,9 @@ type HandlerMethodDecorator = (
     | TypedPropertyDescriptor<AsyncHandler<Handler>>
 ) => void;
 
-export { LambdaInterface, HandlerMethodDecorator };
+export type {
+  AsyncHandler,
+  SyncHandler,
+  LambdaInterface,
+  HandlerMethodDecorator,
+};

packages/commons/src/types/awsSdk.ts

@@ -19,4 +19,4 @@ interface SdkClient {
  */
 type MiddlewareArgsLike = { request: { headers: { [key: string]: string } } };
 
-export { SdkClient, MiddlewareArgsLike };
+export type { SdkClient, MiddlewareArgsLike };

packages/commons/src/types/index.ts

@@ -1,11 +1,16 @@
-export {
+export type {
   MiddlewareLikeObj,
   MiddyLikeRequest,
   CleanupFunction,
 } from './middy.js';
-export { SdkClient, MiddlewareArgsLike } from './awsSdk.js';
-export { JSONPrimitive, JSONValue, JSONObject, JSONArray } from './json.js';
-export {
+export type { SdkClient, MiddlewareArgsLike } from './awsSdk.js';
+export type {
+  JSONPrimitive,
+  JSONValue,
+  JSONObject,
+  JSONArray,
+} from './json.js';
+export type {
   SyncHandler,
   AsyncHandler,
   LambdaInterface,

packages/commons/src/types/middy.ts

@@ -57,4 +57,4 @@ type MiddyLikeRequest = {
  */
 type CleanupFunction = (request: MiddyLikeRequest) => Promise<void>;
 
-export { MiddlewareLikeObj, MiddyLikeRequest, CleanupFunction };
+export type { MiddlewareLikeObj, MiddyLikeRequest, CleanupFunction };