🐛 Fix empty resource file bug

[RocKhalil]

This PR fixes an issue when generating a resource and the database connection is not working.
Currently, it creates an empty file, but with catching the error, it will generate the file with the default template:

class Avo::Resources::<%= resource_class %> < Avo::BaseResource
  self.includes = []<%= model_class_from_args %>
  # self.search = {
  #   query: -> { query.ransack(id_eq: params[:q], m: "or").result(distinct: false) }
  # }

  def fields
    field :id, as: :id
  end
end

[qlty-cloud-legacy]

Code Climate has analyzed commit 6d5b00d and detected 0 issues on this pull request.

View more on Code Climate.

[adrianthedev]

Can you please remove all the style changes?

[Paul-Bob]

It looks great, thanks for the contribution!

I was thinking if we should use the rescue_from at the class level and avoid repeating the rescue on multiple methods

rescue_from ActiveRecord::NoDatabaseError, with: :no_database_error
def no_database_error
  puts "Database not found, please create your database and regenerate the resource."
  []
end

The current state of the PR is good to merge IMO, just wondering about ☝️

[adrianthedev]

Shouldn't these return emtpy arrays too?

[Paul-Bob]

Not on this method, only if the exception start being rescued on model_db_columns

[RocKhalil]

Correct; so I have moved the rescue to model_db_columns instead

[Paul-Bob]

Good move since that's the origin of the exception.

Ready to merge 👌

[adrianthedev]

Thanks for the contribution @RocKhalil