[flake8-logging-format] Avoid dropping implicitly concatenated pieces in the G004 fix
#20793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: ``` cargo test -p ruff_linter ``` Backtest (run new testcases against previous implementation): ``` git checkout HEAD^ crates/ruff_linter/src/rules/flake8_logging_format/rules/logging_call.rs cargot test -p ruff_linter ```
Contributor
|
ntBre
added
bug
ntBre
approved these changes
Oct 9, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Very nice, thank you!
Yeah, f_strings does seem a bit risky to use, I certainly didn't realize this when reviewing the fix initially. I quickly went through the other references, and they look correct at least.
It also seems a bit unfortunate that we join the implicitly concatenated parts, but we could follow up on that separately.
ntBre
changed the title
flake8-logging-format] Avoid dropping implicitly concatenated pieces in the G004 fix
Contributor
Author
|
Thanks for the quick review @ntBre ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original autofix for G004 was quietly dropping everything but the f-string components of any implicit concatenation sequence; this addresses that.
Side note: It looks like
f_stringsis a bit risky to use (since it implicitly skips non-f-string parts); use iter and include implicitly concatenated pieces. We should consider if it's worth having (convenience vs. bit risky).Test Plan
Backtest (run new testcases against previous implementation):