Bump MSRV to Rust 1.88 #20470
Merged
Bump MSRV to Rust 1.88 #20470
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
commented
Sep 18, 2025
| if let Some(diff) = Diff::from_diagnostic(diag, &stylesheet, self.resolver) { | ||
| write!(f, "{diff}")?; | ||
| } | ||
| if self.config.show_fix_diff |
Member
Author
There was a problem hiding this comment.
Funny how this is the only place where clippy identified the possibility to use if-let chains
ntBre
approved these changes
Sep 18, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
I just merged the conda-forge PR!
BurntSushi
approved these changes
Sep 18, 2025
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Rust MSRV to Rust 1.88 in accordance to our versioning policy.
This needs conda-forge/ruff-feedstock#296