Review findings

Author: sharkdp

crates/ty_python_semantic/resources/mdtest/statically_known_branches.md

@@ -1567,8 +1567,7 @@ from module import symbol
 ## Non-definitely bound symbols in conditions
 
 When a non-definitely bound symbol is used as a (part of a) condition, we always infer an ambiguous
-truthiness. If we wouldn't do that, `x` would be considered definitely bound in the following
-example:
+truthiness. If we didn't do that, `x` would be considered definitely bound in the following example:
 
 ```py
 def _(flag: bool):

crates/ty_python_semantic/src/place.rs

@@ -136,7 +136,7 @@ impl<'db> Place<'db> {
         }
     }
 
-    pub(crate) fn is_definitely_bound(&self) -> bool {
+    pub(crate) const fn is_definitely_bound(&self) -> bool {
         matches!(self, Place::Type(_, Boundness::Bound))
     }
 }

crates/ty_python_semantic/src/types.rs

@@ -8624,7 +8624,7 @@ impl TypeRelation {
     }
 }
 
-#[derive(Debug, Copy, Clone, PartialEq, Eq)]
+#[derive(Debug, Copy, Clone, PartialEq, Eq, get_size2::GetSize)]
 pub enum Truthiness {
     /// For an object `x`, `bool(x)` will always return `True`
     AlwaysTrue,
@@ -8634,8 +8634,6 @@ pub enum Truthiness {
     Ambiguous,
 }
 
-impl get_size2::GetSize for Truthiness {}
-
 impl Truthiness {
     pub(crate) const fn is_ambiguous(self) -> bool {
         matches!(self, Truthiness::Ambiguous)

crates/ty_python_semantic/src/types/infer.rs

@@ -339,7 +339,7 @@ fn single_expression_cycle_initial<'db>(
 
 /// Returns the statically-known truthiness of a given expression.
 ///
-/// Returns `Truthiness::Ambiguous` in case any non-definitely bound places
+/// Returns [`Truthiness::Ambiguous`] in case any non-definitely bound places
 /// were encountered while inferring the type of the expression.
 #[salsa::tracked(cycle_fn=static_expression_truthiness_cycle_recover, cycle_initial=static_expression_truthiness_cycle_initial, heap_size=get_size2::GetSize::get_heap_size)]
 pub(crate) fn static_expression_truthiness<'db>(