Skip to content

Commit 5d275e3

Browse files
authored
feat(argo-cd): Add serviceAnnotations support for AWS ALB gRPC service (#3583)
1 parent eb1e669 commit 5d275e3

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

charts/argo-cd/Chart.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ appVersion: v3.2.0
33
kubeVersion: ">=1.25.0-0"
44
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
55
name: argo-cd
6-
version: 9.1.1
6+
version: 9.1.2
77
home: https://github.com/argoproj/argo-helm
88
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
99
sources:
@@ -26,5 +26,5 @@ annotations:
2626
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
2727
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
2828
artifacthub.io/changes: |
29-
- kind: removed
30-
description: Remove `server.rbac.log.enforce.enable` flag in `configs.cm`
29+
- kind: added
30+
description: Add serviceAnnotations support for AWS ALB gRPC service

charts/argo-cd/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1233,6 +1233,7 @@ NAME: my-release
12331233
| server.imagePullSecrets | list | `[]` (defaults to global.imagePullSecrets) | Secrets with credentials to pull images from a private registry |
12341234
| server.ingress.annotations | object | `{}` | Additional ingress annotations |
12351235
| server.ingress.aws.backendProtocolVersion | string | `"GRPC"` | Backend protocol version for the AWS ALB gRPC service |
1236+
| server.ingress.aws.serviceAnnotations | object | `{}` | Annotations for the AWS ALB gRPC service |
12361237
| server.ingress.aws.serviceType | string | `"NodePort"` | Service type for the AWS ALB gRPC service |
12371238
| server.ingress.controller | string | `"generic"` | Specific implementation for ingress controller. One of `generic`, `aws` or `gke` |
12381239
| server.ingress.enabled | bool | `false` | Enable an ingress resource for the Argo CD server |

charts/argo-cd/templates/argocd-server/aws/service.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,13 @@ kind: Service
44
metadata:
55
annotations:
66
alb.ingress.kubernetes.io/backend-protocol-version: {{ .Values.server.ingress.aws.backendProtocolVersion }}
7+
{{- with .Values.server.ingress.aws.serviceAnnotations }}
8+
{{- range $key, $value := . }}
9+
{{ $key }}: {{ $value | quote }}
10+
{{- end }}
11+
{{- end }}
712
labels:
8-
{{- include "argo-cd.labels" (dict "context" . "component" (print .Values.server.name "-gprc") "name" (print .Values.server.name "-grpc")) | nindent 4 }}
13+
{{- include "argo-cd.labels" (dict "context" . "component" (print .Values.server.name "-grpc") "name" (print .Values.server.name "-grpc")) | nindent 4 }}
914
name: {{ template "argo-cd.server.fullname" . }}-grpc
1015
namespace: {{ include "argo-cd.namespace" . }}
1116
spec:

charts/argo-cd/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2472,6 +2472,9 @@ server:
24722472
## Instance mode needs type NodePort, IP mode needs type ClusterIP
24732473
## Ref: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/how-it-works/#ingress-traffic
24742474
serviceType: NodePort
2475+
# -- Annotations for the AWS ALB gRPC service
2476+
## Allows adding custom annotations to the gRPC service for integrations like DataDog, Prometheus, etc.
2477+
serviceAnnotations: {}
24752478

24762479
# Google specific options for Google Application Load Balancer
24772480
# Applies only when `server.ingress.controller` is set to `gke`

0 commit comments

Comments
 (0)