-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: allow devs to run locally a subset of e2e tests #25514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Patroklos Papapetrou <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
reggie-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful! Maybe we can also add that after running make start-e2e-local any separate integration test can be run using the IDE's built-in "run test".
|
I was going to say the exact same thing as you @reggie-k but you beat me to it 😄 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25514 +/- ##
==========================================
+ Coverage 62.45% 62.47% +0.01%
==========================================
Files 351 351
Lines 49490 49490
==========================================
+ Hits 30910 30917 +7
+ Misses 15621 15616 -5
+ Partials 2959 2957 -2 ☔ View full report in Codecov by Sentry. |
olivergondza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! I have suggested some improvements...
Signed-off-by: Patroklos Papapetrou <[email protected]>
Signed-off-by: Patroklos Papapetrou <[email protected]>
|
@olivergondza @reggie-k @blakepettersson I think I addressed all your excellent comments!! |
olivergondza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. (I have not tested all variants of test/e2e with -local)
Checklist:
As explained in the docs some times is very useful to run only a subset of tests, especially when adding new ones or changing code in given code area.
this small change allows devs to easily run a subset of the e2e tests