Skip to content

Conversation

@ppapapetrou76
Copy link
Contributor

@ppapapetrou76 ppapapetrou76 commented Dec 4, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

As explained in the docs some times is very useful to run only a subset of tests, especially when adding new ones or changing code in given code area.

this small change allows devs to easily run a subset of the e2e tests

@ppapapetrou76 ppapapetrou76 requested review from a team as code owners December 4, 2025 13:47
@bunnyshell
Copy link

bunnyshell bot commented Dec 4, 2025

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful! Maybe we can also add that after running make start-e2e-local any separate integration test can be run using the IDE's built-in "run test".

@blakepettersson
Copy link
Member

I was going to say the exact same thing as you @reggie-k but you beat me to it 😄

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.47%. Comparing base (7cdc0f9) to head (da24f44).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25514      +/-   ##
==========================================
+ Coverage   62.45%   62.47%   +0.01%     
==========================================
  Files         351      351              
  Lines       49490    49490              
==========================================
+ Hits        30910    30917       +7     
+ Misses      15621    15616       -5     
+ Partials     2959     2957       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olivergondza olivergondza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! I have suggested some improvements...

Signed-off-by: Patroklos Papapetrou <[email protected]>
Signed-off-by: Patroklos Papapetrou <[email protected]>
@ppapapetrou76
Copy link
Contributor Author

@olivergondza @reggie-k @blakepettersson I think I addressed all your excellent comments!!
Can you please have another look?

Copy link
Contributor

@olivergondza olivergondza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. (I have not tested all variants of test/e2e with -local)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants