feat: read argocd password from stdin (#23520)

Signed-off-by: nitishfy <[email protected]>

Author: nitishfy

cmd/argocd/commands/login.go

@@ -185,8 +185,7 @@ argocd login cd.argoproj.io --core`,
 	command.Flags().StringVar(&password, "password", "", "The password of an account to authenticate")
 	command.Flags().BoolVar(&sso, "sso", false, "Perform SSO login")
 	command.Flags().IntVar(&ssoPort, "sso-port", DefaultSSOLocalPort, "Port to run local OAuth2 login application")
-	command.Flags().
-		BoolVar(&skipTestTLS, "skip-test-tls", false, "Skip testing whether the server is configured with TLS (this can help when the command hangs for no apparent reason)")
+	command.Flags().BoolVar(&skipTestTLS, "skip-test-tls", false, "Skip testing whether the server is configured with TLS (this can help when the command hangs for no apparent reason)")
 	command.Flags().BoolVar(&ssoLaunchBrowser, "sso-launch-browser", true, "Automatically launch the system default browser when performing SSO login")
 	return command
 }

util/cli/cli.go

@@ -102,12 +102,21 @@ func PromptMessage(message, value string) string {
 	return value
 }
 
-// PromptPassword prompts the user for a password, without local echo. (unless already supplied)
+// PromptPassword prompts the user for a password, without local echo (unless already supplied).
+// If terminal.ReadPassword fails — often due to stdin not being a terminal (e.g., when input is piped),
+// we fall back to reading from standard input using bufio.Reader.
 func PromptPassword(password string) string {
 	for password == "" {
 		fmt.Print("Password: ")
 		passwordRaw, err := terminal.ReadPassword(int(os.Stdin.Fd()))
-		errors.CheckError(err)
+		if err != nil {
+			// Fallback: handle cases where stdin is not a terminal (e.g., piped input)
+			reader := bufio.NewReader(os.Stdin)
+			input, err := reader.ReadString('\n')
+			errors.CheckError(err)
+			password = strings.TrimSpace(input)
+			return password
+		}
 		password = string(passwordRaw)
 		fmt.Print("\n")
 	}

util/cli/cli_test.go

@@ -0,0 +1,31 @@
+package cli
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+const pwd = "test-password"
+
+func TestPromptPassword_Fallback(t *testing.T) {
+	oldStdin := os.Stdin
+	defer func() {
+		os.Stdin = oldStdin
+	}()
+
+	r, w, err := os.Pipe()
+	if err != nil {
+		t.Fatalf("Failed to create pipe: %v", err)
+	}
+	_, err = w.WriteString(pwd + "\n")
+	if err != nil {
+		t.Fatalf("Failed to write to pipe: %v", err)
+	}
+	w.Close()
+
+	os.Stdin = r
+	password := PromptPassword("")
+	require.Equal(t, pwd, password)
+}