refactor: migrate from go-json-experiment to encoding/json/v2 #9422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration replaces github.com/go-json-experiment/json with the official encoding/json/v2 package introduced in Go 1.25. Changes: - Update Go version to 1.25 - Replace all imports from go-json-experiment/json to encoding/json/v2 - Replace all imports from go-json-experiment/json/jsontext to encoding/json/jsontext - Remove external dependency from go.mod - Configure mage to use GOEXPERIMENT=jsonv2 for all build commands - All tests pass with the experimental json/v2 package Requires GOEXPERIMENT=jsonv2 environment variable until json/v2 becomes default.
- Update golangci-lint configuration to Go 1.25 - Add GOEXPERIMENT=jsonv2 to GitHub Actions lint step - Update golangci-lint version in cache workflow - Add GOEXPERIMENT=jsonv2 to magefiles (already done by user)
- Fix import ordering in all files using encoding/json/v2 - Add ENV to modernize tool invocations in magefiles - Ensure consistent import grouping per gci rules
knqyf263
added
the
autoready
knqyf263
changed the title
github-actions
bot
removed
the
autoready
github-actions
bot
requested review from
DmitriyLewen and
nikpivkin
as code owners
DmitriyLewen
approved these changes
Sep 4, 2025
Collaborator
Author
|
@nikpivkin Can you please take a look? I remember you introduced the package. I'd request your review. |
Member
@knqyf263 Nikita is currently away on vacation he will be back on 14th. |
simar7
approved these changes
Sep 10, 2025
Member
simar7
left a comment
simar7
left a comment
There was a problem hiding this comment.
Yesterday the team published an official blog post which is a good read https://go.dev/blog/jsonv2-exp
Collaborator
Author
Thanks. Yes, I remembered that right after asking him. This PR is not urgent. I'll wait for him. |
nikpivkin
approved these changes
Sep 15, 2025
knqyf263
added a commit
to knqyf263/trivy
that referenced
this pull request
Sep 19, 2025
…curity#9422) Co-authored-by: knqyf263 <[email protected]> Co-authored-by: nikpivkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates from the experimental
github.com/go-json-experiment/jsonpackage to the newencoding/json/v2package that is available in Go 1.25 as an experimental feature.Changes
go.modfd.axjsq.dpdns.org/go-json-experiment/jsontoencoding/json/v2fd.axjsq.dpdns.org/go-json-experiment/json/jsontexttoencoding/json/jsontextGOEXPERIMENT=jsonv2to the build environment in magefilesfd.axjsq.dpdns.org/go-json-experiment/jsonfromgo.modContext
Go 1.25 introduces experimental support for
encoding/json/v2.The new package is enabled by setting
GOEXPERIMENT=jsonv2at build time, which has been configured in our build system.Notes
GOEXPERIMENT=jsonv2flag which enables the new JSON implementationgo-json-experimentpackageReferences
Checklist