Skip to content

Conversation

@chen-keinan
Copy link
Contributor

Description

support skip-deep scanning flag

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).

@chen-keinan chen-keinan changed the title feat: support skip-deep scanning flag feat: support --skip-deep scanning flag Mar 17, 2024
@chen-keinan chen-keinan marked this pull request as ready for review March 18, 2024 14:40
@chen-keinan chen-keinan requested a review from knqyf263 as a code owner March 18, 2024 14:40
@itaysk
Copy link
Contributor

itaysk commented Apr 3, 2024

we discussed this offline and agreed to call the flag --skip-images, to better convey the meaning of this flag, and also to align with other trivy terminology. the flag will be boolean

@chen-keinan chen-keinan changed the title feat: support --skip-deep scanning flag feat: support --skip-images scanning flag Apr 3, 2024
@chen-keinan chen-keinan force-pushed the feat/support-skip-deep branch 2 times, most recently from 7d57741 to 0f79a25 Compare April 3, 2024 09:33
@knqyf263
Copy link
Collaborator

knqyf263 commented Apr 3, 2024

We need documentation regarding this flag. At first glance, it was hard for me to imagine how it would work.

@chen-keinan chen-keinan force-pushed the feat/support-skip-deep branch from 6ae4907 to a2e4ee8 Compare April 4, 2024 06:46
@chen-keinan chen-keinan requested a review from simar7 April 4, 2024 15:44
@knqyf263
Copy link
Collaborator

I'm still waiting for the document update.

@chen-keinan chen-keinan force-pushed the feat/support-skip-deep branch from 859371a to f660185 Compare April 27, 2024 15:55
@chen-keinan chen-keinan added this pull request to the merge queue May 2, 2024
Merged via the queue into aquasecurity:main with commit e739ab8 May 2, 2024
@chen-keinan chen-keinan deleted the feat/support-skip-deep branch May 2, 2024 12:12
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trivy k8s: --skip-images flag

4 participants