-
Notifications
You must be signed in to change notification settings - Fork 13
Add GHA to install all the supported Debian/Ubuntu #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YuviGold
wants to merge
1
commit into
aquasecurity:main
Choose a base branch
from
YuviGold:add-gha-install
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Install | ||
| on: [push] | ||
| jobs: | ||
| install-ubuntu: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| image: [ | ||
| "ubuntu:20.04", | ||
| "ubuntu:18.04", | ||
| "ubuntu:16.04", | ||
| "ubuntu:14.04", | ||
| ] | ||
|
|
||
| container: | ||
| image: ${{ matrix.image }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| with: | ||
| fetch-depth: 1 | ||
| - run: ./install_deb.sh | ||
|
|
||
| install-debian: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| image: [ | ||
| "debian:10", | ||
| "debian:9" | ||
| ] | ||
|
|
||
| container: | ||
| image: ${{ matrix.image }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| with: | ||
| fetch-depth: 1 | ||
| - run: ./install_deb.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -o nounset | ||
| set -o pipefail | ||
| set -o errexit | ||
| set -o xtrace | ||
|
|
||
| # Install prerequisites | ||
| apt-get update | ||
| apt-get install -y wget gnupg lsb-release | ||
|
|
||
|
|
||
| # Install script | ||
| apt-get install -y apt-transport-https | ||
| wget -qO - https://aquasecurity.github.io/trivy-repo/deb/public.key | apt-key add - | ||
| echo deb https://aquasecurity.github.io/trivy-repo/deb $(lsb_release -sc) main | tee -a /etc/apt/sources.list | ||
| apt-get update | ||
| apt-get install -y trivy | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to remove these hard-coded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYM? I added them in the purpose of covering the supported versions. You can put w/e container image you want in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot maintain these values every time Ubuntu releases a new version. Can we fetch all the versions supported by Ubuntu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to get all the supported versions it means to fetch somehow all the active LTS versions. https://endoflife.date/ubuntu
Umm, it's possible, but it'll be complex.
I can add the
ubuntu:latesttag to at least be informed about any new version that becomes unsupported.How do you currently maintain the releases? Do you automatically add/remove versions according to their EOL (active support/security support)?
If so, it should work with the same scripts/API.
Otherwise, you might want to open another issue to support those values automatically, it will require more time.