-
Notifications
You must be signed in to change notification settings - Fork 475
flag(log): new flag format #4999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
==========================================
+ Coverage 29.72% 30.77% +1.04%
==========================================
Files 234 235 +1
Lines 26186 26753 +567
==========================================
+ Hits 7785 8232 +447
- Misses 17864 17974 +110
- Partials 537 547 +10
🚀 New features to boost your workflow:
|
26eec40 to
1f7f81c
Compare
|
Overall LGTM, but:
|
3609d26 to
e3d8f7c
Compare
yanivagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e3d8f7c to
e3b01df
Compare
c149859 to
e5f7117
Compare
8dc5d51 to
df0b45f
Compare
|
The documentation error, is because the script doesn't consider renames |
df0b45f to
c9eb3e2
Compare
geyslan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Put just some thoughts.
c9eb3e2 to
0974323
Compare
BREAKING CHANGE: add --logging to replace --log
0974323 to
4467f53
Compare
Changes:
--log level:debugto--log level=debug--log filter:msg=errorto--log filter.include.msg=errorlevel:tolvl:in config for consistencyExamples:
Old flag format (deprecated):
New flag format:
Old config format (deprecated):
New config format:
Testing: All existing tests updated + comprehensive test coverage for new format.