feature: Add AttachProgs/DetachProgs api for bpf object #409
Conversation
geyslan
left a comment
geyslan
left a comment
There was a problem hiding this comment.
@chentao-kernel thank you for this contrib.
As the proposal is to emulate bpf_object__attach_skeleton and bpf_object__detach_skeleton, some behaviours have to be replicated. I've put comments below.
Please check also for the selftest failure: https://github.com/aquasecurity/libbpfgo/actions/runs/8326584366/job/22782547013?pr=409
chentao-kernel
force-pushed
the
dylane/attach_progs
branch
from
d106dae to
4d48d28
Compare
Signed-off-by: Tao Chen <[email protected]>
chentao-kernel
force-pushed
the
dylane/attach_progs
branch
from
6199fe4 to
9f902da
Compare
Thank you for your review! |
Ok, i will check the failed case. |
Hi geyslan, the failed case seems confused, it dose not display which case really failed. And i try again, all |
Ok, disregard this, it was due to selftest/iter, possibly a network issue. |
chentao-kernel
force-pushed
the
dylane/attach_progs
branch
4 times, most recently
from
1522093 to
6865720
Compare
|
@chentao-kernel take a look at this: chentao-kernel#2 |
chentao-kernel
force-pushed
the
dylane/attach_progs
branch
from
6865720 to
9581375
Compare
It introduces api for bpf object like api in libbpf: bpf_object__attach_skeleton/bpf_object__detach_skeleton. So we don't need to specify the program name to attach one by one. Signed-off-by: Tao Chen <[email protected]> CC: Dylane Chen <[email protected]> Co-authored-by: Geyslan Gregório <[email protected]>
Signed-off-by: Tao Chen <[email protected]> CC: Dylane Chen <[email protected]> Co-authored-by: Geyslan Gregório <[email protected]>
chentao-kernel
force-pushed
the
dylane/attach_progs
branch
from
9581375 to
5b49136
Compare
@geyslan Hi, geyslan, thank you for your cooperation, i have merged it. |
|
@chentao-kernel thanks again for your contribution. |
2 participants
Add AttachProgs/DetachProgs api for bpf object like api in libbpf: bpf_object__attach_skeleton/bpf_object__detach_skeleton. So we don't need to specify the program name to attach one by one.