Skip to content

Conversation

@liunaijie
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Options.key("url")
.stringType()
.noDefaultValue()
.withFallbackKeys("base-url")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are few changes:

  1. unified the parameter, url, base-url it's same parameters, merge them into same option.

Options.key("compatible_mode")
.stringType()
.noDefaultValue()
.withFallbackKeys("compatibleMode")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Options.key("username")
.stringType()
.noDefaultValue()
.withFallbackKeys("user")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@liunaijie liunaijie marked this pull request as ready for review July 7, 2025 09:09
@corgy-w
Copy link
Contributor

corgy-w commented Jul 8, 2025

Given the changes to several parameters, would it be advisable to modify the default E2E configuration

@Hisoka-X
Copy link
Member

Hisoka-X commented Jul 8, 2025

Given the changes to several parameters, would it be advisable to modify the default E2E configuration

+1. We need add some test case to make sure two config way both worked.

@github-actions github-actions bot added document core SeaTunnel core module e2e labels Jul 22, 2025
@liunaijie
Copy link
Member Author

Given the changes to several parameters, would it be advisable to modify the default E2E configuration

Done. PTAL @corgy-w @Hisoka-X

The file change is increase to 200, but most of them are E2E config change and document update.

Copy link
Contributor

@corgy-w corgy-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TKS

@Hisoka-X
Copy link
Member

Thanks @liunaijie !

@Hisoka-X Hisoka-X merged commit d041e5f into apache:dev Jul 25, 2025
5 checks passed
@liunaijie liunaijie deleted the improve/jdbc_options branch August 8, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants