-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[improve] jdbc options #9541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] jdbc options #9541
Conversation
| Options.key("url") | ||
| .stringType() | ||
| .noDefaultValue() | ||
| .withFallbackKeys("base-url") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are few changes:
- unified the parameter, url, base-url it's same parameters, merge them into same option.
| Options.key("compatible_mode") | ||
| .stringType() | ||
| .noDefaultValue() | ||
| .withFallbackKeys("compatibleMode") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
| Options.key("username") | ||
| .stringType() | ||
| .noDefaultValue() | ||
| .withFallbackKeys("user") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
|
Given the changes to several parameters, would it be advisable to modify the default E2E configuration |
+1. We need add some test case to make sure two config way both worked. |
corgy-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TKS
|
Thanks @liunaijie ! |
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide