Skip to content

Conversation

@LuigiDurso
Copy link
Contributor

Upgrades the Iceberg dependency to version 1.6.1.

This ensures compatibility with custom oauth token uri.

This pull request updates the Iceberg dependency in the seatunnel-connectors-v2/connector-iceberg/pom.xml file to a newer version.

Dependency update:

  • Updated the iceberg.version property from 1.4.2 to 1.6.1 to ensure compatibility with the latest features and fixes in Iceberg. ([seatunnel-connectors-v2/connector-iceberg/pom.xmlL33-R33](https://github.com/apache/seatunnel/pull/9451/files#diff-cbb0301376499c039b2b41bd654c3a037e2ca60a0b21c0adaabaff7fded4dfceL33-R33))

@Hisoka-X
Copy link
Member

Thanks @LuigiDurso ! Could you follow the guide to open ci in your fork repository? https://github.com/apache/seatunnel/pull/9451/checks?check_run_id=44271538658

@Hisoka-X Hisoka-X linked an issue Jun 18, 2025 that may be closed by this pull request
3 tasks
@nielifeng nielifeng requested a review from Copilot June 18, 2025 06:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Iceberg dependency to version 1.6.1 for improved compatibility with custom OAuth token URIs.

  • Bumps iceberg.version from 1.4.2 to 1.6.1 in the Iceberg connector POM.
  • Aligns the connector with Iceberg 1.6.1 features and fixes.
Comments suppressed due to low confidence (2)

seatunnel-connectors-v2/connector-iceberg/pom.xml:33

  • Add or update integration tests to verify that the connector works correctly with Iceberg 1.6.1, especially around custom OAuth token URI handling.
        <iceberg.version>1.6.1</iceberg.version>

seatunnel-connectors-v2/connector-iceberg/pom.xml:33

  • [nitpick] Consider adding a comment near this property to explain that the version bump to 1.6.1 is required for custom OAuth token URI compatibility.
        <iceberg.version>1.6.1</iceberg.version>

Upgrades the Iceberg dependency to version 1.6.1.

This ensures compatibility with custom oauth token uri.
@LuigiDurso LuigiDurso force-pushed the fix/iceberg-update branch from fc5e1d4 to c116bb1 Compare June 18, 2025 14:27
@Hisoka-X
Copy link
Member

Please re-trigger the failed ci.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuigiDurso ! Please udpate https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/Iceberg.md?plain=1#L9 too. And other 3 docs (sink and zh source and sink)

Updates the supported Iceberg version in the documentation
for both sink and source connectors in English and Chinese.
@corgy-w corgy-w merged commit 7b92a6c into apache:dev Jul 8, 2025
5 checks passed
dybyte pushed a commit to dybyte/seatunnel that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Connector-V2] Cannot specify custom OAuth2 URI on Iceberg REST Catalog

3 participants