-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Bug] [Connector-V2] Updates Iceberg version to 1.6.1 (#9387) #9451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @LuigiDurso ! Could you follow the guide to open ci in your fork repository? https://github.com/apache/seatunnel/pull/9451/checks?check_run_id=44271538658 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Iceberg dependency to version 1.6.1 for improved compatibility with custom OAuth token URIs.
- Bumps
iceberg.versionfrom1.4.2to1.6.1in the Iceberg connector POM. - Aligns the connector with Iceberg 1.6.1 features and fixes.
Comments suppressed due to low confidence (2)
seatunnel-connectors-v2/connector-iceberg/pom.xml:33
- Add or update integration tests to verify that the connector works correctly with Iceberg 1.6.1, especially around custom OAuth token URI handling.
<iceberg.version>1.6.1</iceberg.version>
seatunnel-connectors-v2/connector-iceberg/pom.xml:33
- [nitpick] Consider adding a comment near this property to explain that the version bump to 1.6.1 is required for custom OAuth token URI compatibility.
<iceberg.version>1.6.1</iceberg.version>
Upgrades the Iceberg dependency to version 1.6.1. This ensures compatibility with custom oauth token uri.
fc5e1d4 to
c116bb1
Compare
|
Please re-trigger the failed ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuigiDurso ! Please udpate https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/Iceberg.md?plain=1#L9 too. And other 3 docs (sink and zh source and sink)
Updates the supported Iceberg version in the documentation for both sink and source connectors in English and Chinese.
Upgrades the Iceberg dependency to version 1.6.1.
This ensures compatibility with custom oauth token uri.
This pull request updates the Iceberg dependency in the
seatunnel-connectors-v2/connector-iceberg/pom.xmlfile to a newer version.Dependency update:
iceberg.versionproperty from1.4.2to1.6.1to ensure compatibility with the latest features and fixes in Iceberg. ([seatunnel-connectors-v2/connector-iceberg/pom.xmlL33-R33](https://github.com/apache/seatunnel/pull/9451/files#diff-cbb0301376499c039b2b41bd654c3a037e2ca60a0b21c0adaabaff7fded4dfceL33-R33))