Skip to content

Conversation

@ShuiMu-peng
Copy link
Contributor

Purpose of this pull request

Doc: 1. Link error. 2.DynamoDB connection parameter error

Does this PR introduce any user-facing change?

  1. It turned out that some links to the Chinese documents pointed to the English document addresses
  2. The parameters of the Dynamodb connector are incorrect

How was this patch tested?

No test is needed.

Check list

@nielifeng nielifeng requested a review from Copilot June 17, 2025 01:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several documentation pages to correct broken links and fixes DynamoDB connection parameter names. The changes ensure that the Chinese docs reference the proper relative file paths and that the DynamoDB parameters use snake_case for consistency.

  • Updated relative links in various docs to point to the correct local resources.
  • Corrected DynamoDB parameter names from accessKeyId/secretAccessKey to access_key_id/secret_access_key.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/zh/start-v2/locally/quick-start-spark.md Updated link for Spark documentation
docs/zh/connector-v2/sink/HdfsFile.md Updated link for connector feature reference
docs/zh/connector-v2/sink/Assert.md Revised link for FakeSource usage example
docs/zh/connector-v2/sink/AmazonDynamoDB.md Changed parameter names for DynamoDB connection
docs/zh/concept/config.md Updated relative links for source, transform, and sink
docs/zh/concept/JobEnvConfig.md Updated relative link for config encryption documentation

@Hisoka-X
Copy link
Member

Thanks @ShuiMu-peng . Could you follow the guide to open ci on your fork repository? https://github.com/apache/seatunnel/pull/9447/checks?check_run_id=44221269862

@ShuiMu-peng
Copy link
Contributor Author

ShuiMu-peng commented Jun 17, 2025

Ok. ci has been enabled @Hisoka-X

@Hisoka-X Hisoka-X changed the title [docs] 1. Link error. 2.DynamoDB connection parameter error [Doc] Fix link error and DynamoDB parameter error Jun 18, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It has been updated

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @ShuiMu-peng

@hailin0 hailin0 merged commit 0250cfb into apache:dev Jun 19, 2025
5 checks passed
chncaesar pushed a commit to chncaesar/seatunnel that referenced this pull request Jun 30, 2025
dybyte pushed a commit to dybyte/seatunnel that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants