-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Doc] Fix link error and DynamoDB parameter error #9447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several documentation pages to correct broken links and fixes DynamoDB connection parameter names. The changes ensure that the Chinese docs reference the proper relative file paths and that the DynamoDB parameters use snake_case for consistency.
- Updated relative links in various docs to point to the correct local resources.
- Corrected DynamoDB parameter names from accessKeyId/secretAccessKey to access_key_id/secret_access_key.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/zh/start-v2/locally/quick-start-spark.md | Updated link for Spark documentation |
| docs/zh/connector-v2/sink/HdfsFile.md | Updated link for connector feature reference |
| docs/zh/connector-v2/sink/Assert.md | Revised link for FakeSource usage example |
| docs/zh/connector-v2/sink/AmazonDynamoDB.md | Changed parameter names for DynamoDB connection |
| docs/zh/concept/config.md | Updated relative links for source, transform, and sink |
| docs/zh/concept/JobEnvConfig.md | Updated relative link for config encryption documentation |
|
Thanks @ShuiMu-peng . Could you follow the guide to open ci on your fork repository? https://github.com/apache/seatunnel/pull/9447/checks?check_run_id=44221269862 |
|
Ok. ci has been enabled @Hisoka-X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update https://github.com/apache/seatunnel/blob/dev/docs/zh/connector-v2/source/AmazonDynamoDB.md#accesskeyid-string and english doc of AmazonDynamoDB.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. It has been updated
Hisoka-X
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passes. Thanks @ShuiMu-peng
Purpose of this pull request
Doc: 1. Link error. 2.DynamoDB connection parameter error
Does this PR introduce any user-facing change?
How was this patch tested?
No test is needed.
Check list
New License Guide