-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[bug][dist]fix the release packaging exception #9436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the release packaging exception by removing duplicate dependency declarations using invalid version placeholders.
- Removed the presto and trino version properties.
- Removed the presto-jdbc and trino-jdbc dependency blocks that used those properties.
Comments suppressed due to low confidence (2)
seatunnel-dist/pom.xml:111
- Removing the 'presto.version' property resolves the version placeholder error; please verify that no build configuration relies on this property.
<presto.version>0.279</presto.version>
seatunnel-dist/pom.xml:984
- The removal of the presto-jdbc and trino-jdbc dependency blocks eliminates duplicate declaration issues and invalid version references; ensure these dependencies are not required for release functionality.
<dependency> block for presto-jdbc and trino-jdbc
| <classifier>optional</classifier> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to profile id seatunnel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified
|
waiting test case passes. |
Purpose of this pull request
mvn clean package -pl :seatunnel-dist -am -D"skip.ui"=true -DskipTests -Preleasethrow errorDoes this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide