[Fix][Connector-V2] Fix prometheus check time can not parse double value #9311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in the Prometheus connector related to time parameter parsing for Prometheus checks. Key changes include:
- Adding comprehensive tests in PrometheusParamCheckTest to validate multiple time formats.
- Modifying the time validation in PrometheusSourceParameter to support numeric timestamps.
- Updating the ISO8601 parsing to use Instant.parse for improved clarity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-prometheus/src/test/java/org/apache/seatunnel/connectors/seatunnel/prometheus/PrometheusParamCheckTest.java | Added test cases to cover valid ISO8601, numeric, and CURRENT_TIMESTAMP time formats. |
| seatunnel-connectors-v2/connector-prometheus/src/main/java/org/apache/seatunnel/connectors/seatunnel/prometheus/config/PrometheusSourceParameter.java | Updated checkTimeParam to change ISO8601 parsing and to validate numeric time parameters. |
| ZonedDateTime now = ZonedDateTime.now(); | ||
| return now.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME); | ||
| } | ||
| if (!time.endsWith("Z")) { |
There was a problem hiding this comment.
The 'checkTimeParam' method does not handle the 'CURRENT_TIMESTAMP' format, which is expected by test cases (e.g., map4). Consider adding an explicit check for 'CURRENT_TIMESTAMP' before attempting to parse the value as a number.
Member
|
waiting for ci passed |
Hisoka-X
reviewed
May 15, 2025
| ZonedDateTime now = ZonedDateTime.now(); | ||
| return now.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME); | ||
| } | ||
| if (!time.endsWith("Z")) { |
Member
There was a problem hiding this comment.
Let's move it under isValidISO8601 method.
Hisoka-X
changed the title
hailin0
approved these changes
May 21, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide