[improve] EasySearch support schema_save_mode/data_save_mode #9310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
May 15, 2025
| } | ||
| ``` | ||
|
|
||
| SAVE_MODE (Add saveMode function) |
Member
There was a problem hiding this comment.
Suggested change
| SAVE_MODE (Add saveMode function) | |
| SAVE_MODE |
| } | ||
| ``` | ||
|
|
||
| 配置表生成策略 (schema_save_mode) |
Member
There was a problem hiding this comment.
Suggested change
| 配置表生成策略 (schema_save_mode) | |
| 配置表生成策略 |
Comment on lines
108
to
110
| // If any exception occurs, we return empty to indicate that save mode is not supported | ||
| // This allows the connector to continue working without save mode functionality | ||
| return Optional.empty(); |
Member
There was a problem hiding this comment.
Let's we should throw exception directly. Because the job not execute as expect.
Comment on lines
164
to
167
| @DisabledOnContainer( | ||
| value = {}, | ||
| type = {EngineType.SPARK, EngineType.FLINK}, | ||
| disabledReason = "Test only one engine for first change") |
Member
There was a problem hiding this comment.
Let's drop index before execute job. Then we can execute it more than once.
Hisoka-X
approved these changes
May 16, 2025
corgy-w
approved these changes
May 17, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EasySearch support schema_save_mode/data_save_mode
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide