[improve] re-struct Zeta Engine config options #8741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liunaijie
commented
Feb 16, 2025
| public static final String EVENT_REPORT_HTTP = "event-report-http"; | ||
| public static final String EVENT_REPORT_HTTP_URL = "url"; | ||
| public static final String EVENT_REPORT_HTTP_HEADERS = "headers"; | ||
| public static class MasterServerConfigOptions { |
Member
Author
There was a problem hiding this comment.
Re-struct this class.
Split the options to MasterServerConfigOptions and SlaveServerConfigOptions
liunaijie
force-pushed
the
improve/server_options
branch
from
37ed69a to
af6a048
Compare
hailin0
approved these changes
Feb 19, 2025
zax1314157
pushed a commit
to zax1314157/seatunnel
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.