Skip to content

Conversation

@jw-itq
Copy link
Contributor

@jw-itq jw-itq commented Jan 6, 2025

Purpose of this pull request

#8455

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0
Copy link
Member

hailin0 commented Jan 6, 2025

Please add e2e and update docs

@hailin0 hailin0 changed the title starrocks implements multi table sink [Feature][Connector-V2] Starrocks implements multi table sink Jan 6, 2025
@jw-itq
Copy link
Contributor Author

jw-itq commented Jan 6, 2025

Please add e2e and update docs

ok,thanks!

@github-actions github-actions bot added the e2e label Jan 7, 2025
}

source {
MySQL-CDC {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me modify this. I'm not using fake-to-starrocks.conf because I want to test incremental data. I'm not using mysqlcdc_to_starrocks_with_schema_change.conf because it uses shop.sql from mysql-cdc, which doesn't contain multiple tables. I'm going to modify this now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there was a problem with my local code. I have fixed it now. Please help me take a look again. Thank you!

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @Hisoka-X

@Hisoka-X Hisoka-X merged commit 55eebfa into apache:dev Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants