[Feature][Connector-V2]Support Doris Fe Node HA #8311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Dec 17, 2024
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
We should make sure the random and ha be supported at the same time. Random pick the address which can be connected.
Contributor
Author
OK, I will modify it according to this idea later |
Contributor
Author
done. |
Hisoka-X
reviewed
Dec 17, 2024
Comment on lines
305
to
310
| } catch (DorisConnectorException e) { | ||
| if (i == feNodesNum - 1) { | ||
| throw new DorisConnectorException( | ||
| DorisConnectorErrorCode.REST_SERVICE_FAILED, e); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Can we sure the exception is must cause by FE unavailable?
Contributor
Author
There was a problem hiding this comment.
Can we sure the exception is must cause by FE unavailable?
I updated the code to catch other potential exceptions.
Hisoka-X
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
The current logic is to randomly select a FE node to connect to, and if it fails, Doris is considered unavailable. We should optimize this by continuously retrying all user-configured FE nodes.
Does this PR introduce any user-facing change?
no
How was this patch tested?
exist tests
Check list
New License Guide
release-note.