Skip to content

Conversation

@liunaijie
Copy link
Member

Purpose of this pull request

Now the sql transform is support inner query, we can use sql like this

select col_a.sub_col_b

But for now, if the sub_col_b is map type. will got exception.

improve this feature to support query map type as latest field.

Why query map type got exception:
when parse the sql, we need return the query column's field type.
if the query column is map, get the column type is too complex. so only support query from map type only once.

Does this PR introduce any user-facing change?

no

How was this patch tested?

update e2e test conf

Check list

c_row.c_string c_string,
c_row.c_inner_row.c_inner_string c_inner_string,
c_row.c_inner_row.c_inner_timestamp c_inner_timestamp,
c_row.c_inner_row.c_map inner_map,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Assert config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update doc.

@liunaijie liunaijie force-pushed the improve/sql_transform branch 2 times, most recently from 1f1d5c8 to 4085e87 Compare September 24, 2024 09:07
@liunaijie liunaijie force-pushed the improve/sql_transform branch from 60ef6d9 to 866866d Compare September 25, 2024 06:18
@liunaijie
Copy link
Member Author

Please update doc.

截屏2024-09-25 21 27 08

current document not right, we can't query map column now, in this fix we can support that.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liunaijie

@Hisoka-X Hisoka-X changed the title [Improve] improve inner sql query for map field type [Improve][Transform] Improve inner sql query for map field type Sep 26, 2024
@hailin0 hailin0 merged commit 41b8530 into apache:dev Sep 27, 2024
@liunaijie liunaijie deleted the improve/sql_transform branch September 29, 2024 11:10
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants