Skip to content

Conversation

@dailai
Copy link
Contributor

@dailai dailai commented Jun 6, 2024

Purpose of this pull request

Add check for the base type between source and sink before write.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai dailai changed the title [Improve][Paimon] Add check for the base type between source and sink [Improve][Paimon] Add check for the base type between source and sink before write. Jun 6, 2024
@dailai dailai force-pushed the hotfix-for-paimon-sink branch 2 times, most recently from 49165a9 to 7b6e4af Compare June 6, 2024 10:05
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dailai for this PR!

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dailai

@hailin0 hailin0 merged commit d56d64f into apache:dev Jun 11, 2024
@dailai dailai deleted the hotfix-for-paimon-sink branch June 13, 2024 08:10
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants