[Improve][Test] Fix test unstable on ResourceManger and EventReport module
#6620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sourceWithRandomResult`
Hisoka-X
commented
Mar 30, 2024
Comment on lines
+251
to
+252
| || s.contains("OkHttp ConnectionPool") | ||
| || s.startsWith("http-report-event-scheduler") |
Member
Author
Hisoka-X
commented
Mar 30, 2024
| if: needs.changes.outputs.api == 'true' | ||
| run: | | ||
| ./mvnw -T 1 -B verify -DskipUT=true -DskipIT=false -D"license.skipAddThirdParty"=true --no-snapshot-updates -pl :connector-seatunnel-e2e-base -am -Pci | ||
| ./mvnw -T 1 -B verify -DskipUT=true -DskipIT=false -D"license.skipAddThirdParty"=true --no-snapshot-updates -pl :connector-seatunnel-e2e-base,:connector-console-seatunnel-e2e -am -Pci |
Member
Author
There was a problem hiding this comment.
Missed test of :connector-console-seatunnel-e2e when api changed. This is why thread check passed in #6419
Hisoka-X
changed the title
testApplyResourceWithRandomResultResourceManger and EventReport module
hailin0
approved these changes
Mar 30, 2024
EricJoy2048
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR try to reduce the frequency of test failures of
testApplyResourceWithRandomResult. We test it in 5 times. This change will make sure the test more stable.Does this PR introduce any user-facing change?
no
How was this patch tested?
exist test.
Check list
New License Guide
release-note.