Skip to content

Conversation

@Hisoka-X
Copy link
Member

Purpose of this pull request

This PR add default implement for SeaTunnelSink::setTypeInfo. So we can remove all implement in SeaTunnelSink if it implement TableSinkFactory. Also remove some prepare method of these SeaTunnelSink.

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test

Check list

@Hisoka-X
Copy link
Member Author

Waiting #5670 be merged.

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for ci test ok

# Conflicts:
#	seatunnel-connectors-v2/connector-assert/src/main/java/org/apache/seatunnel/connectors/seatunnel/assertion/sink/AssertSink.java
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 86cba87 into apache:dev Oct 27, 2023
@Hisoka-X Hisoka-X deleted the change-sink-setTypeInfo-to-default branch October 27, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants