Skip to content

Conversation

@Hisoka-X
Copy link
Member

Purpose of this pull request

Fix get bytes size from LinkHashMap will throw exception at now.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

case "Double[]":
return ((Double[]) v).length * 8;
case "HashMap":
case "LinkedHashMap":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will other types of map be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the data circulated within SeaTunnelRow. We should standardize the type used when creating map type data in SeaTunnelRow to prevent burden on downstream parsing. For now, Hashmap and LinkHashMap are enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EricJoy2048 EricJoy2048 merged commit b1d66c5 into apache:dev Oct 13, 2023
@Hisoka-X Hisoka-X deleted the fix-bytes-with-linkmap branch October 16, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants