Skip to content

Conversation

@Hisoka-X
Copy link
Member

Purpose of this pull request

Fix ReadonlyConfig will lose key, it introduced by #5534

Does this PR introduce any user-facing change?

No

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X requested a review from hailin0 September 26, 2023 09:11
@Hisoka-X Hisoka-X added the bug label Sep 26, 2023
@hailin0 hailin0 added the api label Sep 26, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 36754cc into apache:dev Sep 28, 2023
@Hisoka-X Hisoka-X deleted the fix-readonly-lose-key branch October 8, 2023 03:04
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants