-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Improve] Move get schema logic from Config to ReadonlyConfig #5534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Member
Author
Member
|
How to test sort of keys |
Member
Author
In fact the new test |
hailin0
approved these changes
Sep 25, 2023
ic4y
approved these changes
Sep 26, 2023
ruanwenjun
approved these changes
Sep 26, 2023
Member
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR main do these thing.
CatalogTableUtilwill covert Config to ReadonlyConfig, the use it to read schema.flattenparameter inConfigUtilas a option to avoid flattening config key. (In schema config, flatten config key makes parsing the schema tricky)CatalogTableUtil::getCatalogTablesFromConfigparameter type fromConfigtoReadonlyConfig. (In most of time, we invoke it with TableFactoryContext, so we can get ReadonlyConfig directly).Does this PR introduce any user-facing change?
Yes or no? I rewrite all logic of get schema from config, the expected behavior should remain the same as before, but this is a refactoring of user-facing parts of the code.
How was this patch tested?
add new test.
Check list
New License Guide
release-note.