-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Improvement] [clickhouse-e2e] Enhance ClickHouse E2E testing to trigger multiple checkpoints #5476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| public class ClickhouseIT extends TestSuiteBase implements TestResource { | ||
| private static final Logger LOG = LoggerFactory.getLogger(ClickhouseIT.class); | ||
| private static final String CLICKHOUSE_DOCKER_IMAGE = "yandex/clickhouse-server:22.1.3.7"; | ||
| private static final String CLICKHOUSE_DOCKER_IMAGE = "clickhouse/clickhouse-server:latest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a good idea to change the image to the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruanwenjun ClickhouseSinkCDCChangelogIT uses clickhouse/clickhouse-server:latest. Should we unify it to yandex/clickhouse-server:22.1.3.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @ruanwenjun means don't use latest, the version it represents can be changed at any time. Just use a certain version.
ClickhouseSinkCDCChangelogIT uses clickhouse/clickhouse-server:latest. Should we unify it to yandex/clickhouse-server:22.1.3.7
Just unify use version which clickhouse/clickhouse-server:latest represents. (Seem like is 23.3.13.6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ger multiple checkpoints (apache#5476)

Enhance ClickHouse E2E testing to trigger multiple checkpoints
#5468
Purpose of this pull request
Check list
New License Guide
release-note.