-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MINOR: Remove SPAM URL in Streams Documentation #20321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Remove SPAM URL in Streams Documentation #20321
Conversation
the previous URL http://lambda-architecture.net/ seems to now be controlled by spammers
|
Hi @rauwuckl, thank you for the PR! I clicked on the link and confirm that it redirects to a new and possibly an unsafe URL. I agree with you that the link seems to be controlled by spammers now and could potentially be dangerous. This issue seems minor and I believe the fix is trivial too, so I don't think we need a Jira ticket to track this. Just a small request - could you please rename and prefix the PR title with - Tagging @mjsax @ableegoldman for review as it is related to streams |
change URL to use HTTPS Co-authored-by: Shashank <[email protected]>
|
thanks @shashankhs11 I changed the PR title as you suggested and made the URL use https |
|
I think it is reasonable to include the url from wikipedia as an alternative. LGTM! |
mimaison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for this fix! -- Can we also do a PR against We should also cherry-pick this commit to 4.1 and 4.0 branches, maybe even 3.9, to avoid re-publishing the old url again by default? |
|
I would be happy to help with a PR for I want to acknowledge that this was @rauwuckl’s contribution, and I really appreciate the find and the fix, but I am ready to help. @rauwuckl, please let me know if you were planning to tackle these steps, or I can take a shot at them to keep things moving. |
|
@mimaison you merged this PR could do the cherry-picks. There is no need to do PRs for it, but we can just cherry-pick and push directly. -- If Mickael does not find time for it, I could help out with it. For kafka-site, I let @rauwuckl and @shashankhs11 figure it out, who wants to do a PR. :) |
|
Thank you all for the quick merge. I appreciate it. As per @mjsax suggestion, I submitted pull request #712 against kafka-site. To avoid clutter, I will not submit pull-requests against the mentioned version-branches of this repo. Following the suggestion that @mjsax or @mimaison push these changes directly. |
The previous URL http://lambda-architecture.net/ seems to now be controlled by spammers Co-authored-by: Shashank <[email protected]> Reviewers: Mickael Maison <[email protected]>
The previous URL http://lambda-architecture.net/ seems to now be controlled by spammers Co-authored-by: Shashank <[email protected]> Reviewers: Mickael Maison <[email protected]>
The previous URL http://lambda-architecture.net/ seems to now be controlled by spammers Co-authored-by: Shashank <[email protected]> Reviewers: Mickael Maison <[email protected]>
|
Thanks. Merged the other PR. Also took the liberty to cherry-pick this commit to 4.1, 4.0, and 3.9 branches. -- As we are getting a new RC for 4.0.1 release, it should pickup the change correctly. For 4.1 we need to make sure to not update the web-page docs incorrectly, as the current RC does not contain this fix yet. |
|
Thanks for the backports. Since we're making a new RC for 4.1 we will automatically pick this up. |

the previous URL http://lambda-architecture.net/ seems to now be
controlled by spammers