Skip to content

bug: Eliminate dead round-robin insertion in enforce distribution #19132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gene-bordegaray wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug: Eliminate dead round-robin insertion in enforce distribution #19132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions datafusion/physical-optimizer/src/enforce_distribution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,11 +1276,6 @@ pub fn ensure_distribution(
}
Distribution::HashPartitioned(exprs) => {
// See https://github.com/apache/datafusion/issues/18341#issuecomment-3503238325 for background
if add_roundrobin && !hash_necessary {
// Add round-robin repartitioning on top of the operator
// to increase parallelism.
child = add_roundrobin_on_top(child, target_partitions)?;
}
// When inserting hash is necessary to satisfy hash requirement, insert hash repartition.
if hash_necessary {
child =
Expand Down