-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Clean up PhysicalExprAdapter and PhysicalExprSimplifier #19128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| &mut self, | ||
| expr: Arc<dyn PhysicalExpr>, | ||
| ) -> Result<Arc<dyn PhysicalExpr>> { | ||
| pub fn simplify(&self, expr: Arc<dyn PhysicalExpr>) -> Result<Arc<dyn PhysicalExpr>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is backwards compatible (aside from compiler warnings that the variable doesn't need to be mutable) and means we can keep multiple references, arc it, etc.
|
This is blocked by one of #19129 or #19130, I think either should make it work. Currently some tests fail because we can't prune based on As a follow up to this we should be able to delete |
|
I've merged #19129 into this branch to get CI passing. I'll fix the conflicts once we merge that. |
This is a nice improvement because it:
PhysicalExprAdaptertrait that users might need to implement simpler (less boilerplate for users).