fix(android): Improper serialization of image uri in save instance state #903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
The imageUri field is not properly restored if the activity is killed,
which can cause further issues.
This is because
imageFilePathwas used instead for the imageUri which only contains thepath of the original URI, losing the scheme in the process.
Description
Serialize using
imageUri.toString()instead of using the imageFilePathTesting
paramedic testing + testing with
Don't Keep Activitiesdeveloper option enabled.Checklist
(platform)if this change only applies to one platform (e.g.(android))