-
Notifications
You must be signed in to change notification settings - Fork 58
Add packaging.yaml for Android Studio #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add packaging.yaml for Android Studio sample index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @pedrosax, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new configuration file, packaging.yaml, within the .google/ directory. This file is critical for the internal Google sample packaging process, providing structured metadata that helps Android Studio index and categorize samples, particularly those related to Android, Extended Reality (XR), and Jetpack Compose.
Highlights
- New Configuration File: A new file,
.google/packaging.yaml, has been added to the repository. - Sample Indexing Metadata: This
packaging.yamlfile contains essential metadata for Google's internal sample packaging process, specifically for indexing samples within Android Studio. - Technology and Category Definitions: The added file defines the sample's status as 'PUBLISHED', lists technologies like Android, XR, and Jetpack Compose, and categorizes it under Jetpack, Jetpack Compose Layouts, and Android XR.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a packaging.yaml file for the Android Studio sample index. The metadata is generally well-defined. I have provided one suggestion to improve the sample's discoverability by including more specific API references pertinent to the XR functionalities showcased.
| apiRefs: | ||
| - android:androidx.compose.Composable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve the discoverability of this sample, consider adding more specific API references that are central to the XR functionality demonstrated. The current apiRefs only lists androidx.compose.Composable, which is very general.
Key APIs used in this sample that would be valuable to include are:
androidx.xr.compose.subspace.SpatialPanelandroidx.xr.compose.spatial.Orbiterandroidx.xr.compose.platform.LocalSpatialCapabilities
apiRefs:
- android:androidx.compose.Composable
- android:androidx.xr.compose.subspace.SpatialPanel
- android:androidx.xr.compose.spatial.Orbiter
- android:androidx.xr.compose.platform.LocalSpatialCapabilities
fuentespatrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding apiRefs would be nice, but it's fine to merge this and address that later too
Add packaging.yaml for Android Studio sample index