Fixed requests not being updated when maxRequests is reached #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallet
changed the title
jwallet
force-pushed
the
maxRequests-fix
branch
from
738ab59 to
e71a046
Compare
jwallet
force-pushed
the
maxRequests-fix
branch
from
6fcd623 to
b3e44c9
Compare
jwallet
changed the title
jwallet
changed the title
Owner
|
@jwallet thanks for all of the pull requests you've opened! I'll try my best to test and review them all by the weekend if I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the maxRequests is reached, we pop() the requests array so we always remove the last one when we reached the max, however we did not updated the xhrIdMap value when doing this. I changed this so the xhrIdMap is now getting the requestIndex directly using a function (computed get) and this constante is now a real Map().
I also added a check to make sure we don't print an invalid date like in the screenshot.
I decrased the maxRequests value in App.tsx so you we will catch it early if the issue comes back, but it affects the searchbox since only those 20 will be available, feel free to reapply 500.