sanity

Author: rodireich

airbyte-cdk/bulk/core/extract/src/main/kotlin/io/airbyte/cdk/discover/Field.kt

@@ -46,10 +46,10 @@ interface LosslessFieldType : FieldType {
 
 interface DataField : DataOrMetaField
 
-/*@Deprecated(
+@Deprecated(
     message = "Use `EmittedField` directly instead.",
     replaceWith = ReplaceWith("EmittedField")
-)*/ //TEMP
+)
 typealias Field = EmittedField
 /**
  * Internal equivalent of [io.airbyte.protocol.models.Field] for values which come from the source

airbyte-cdk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/jdbc/DefaultJdbcConstants.kt

@@ -57,6 +57,6 @@ data class DefaultJdbcConstants(
         internal const val FIELD_OVERHEAD_BYTES = 16L
         // We're targeting use of 60% of the available memory in order to allow
         // for some headroom for other garbage collection.
-        internal const val MEM_CAPACITY_RATIO: Double = 0.2
+        internal const val MEM_CAPACITY_RATIO: Double = 0.6
     }
 }

airbyte-cdk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/read/JdbcPartitionsCreator.kt

@@ -227,7 +227,7 @@ class JdbcConcurrentPartitionsCreator<
         }
         val rowByteSizeSample: Sample<Long> = sample.map { (_, rowByteSize: Long) -> rowByteSize }
         streamState.fetchSize = sharedState.jdbcFetchSizeEstimator().apply(rowByteSizeSample)
-        val expectedTableByteSize: Long = /*rowByteSizeSample.sampledValues.sum() * sample.valueWeight*/ 1_000L * 1_000 * 1_000 * 1_000 // TEMP
+        val expectedTableByteSize: Long = rowByteSizeSample.sampledValues.sum() * sample.valueWeight /*1_000L * 1_000 * 1_000 * 1_000*/ // TEMP
         log.info { "Table memory size estimated at ${expectedTableByteSize shr 20} MiB." }
         // Handle edge case where the table can't be split.
         if (partition !is JdbcSplittablePartition<*>) {

airbyte-cdk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/read/SelectQuerier.kt

@@ -94,7 +94,7 @@ class JdbcSelectQuerier(
         /** Initializes a connection and readies the resultset. */
         fun initQueryExecution() {
             conn = jdbcConnectionFactory.get()
-            conn?.autoCommit = false // TEMP
+//            conn?.autoCommit = false // TEMP
             stmt = conn!!.prepareStatement(q.sql)
             parameters.statementFetchSize?.let { fetchSize: Int ->
                 log.info { "Setting Statement fetchSize to $fetchSize." }

airbyte-integrations/connectors/source-postgres/src/main/kotlin/io/airbyte/integrations/source/postgres/PostgresSourceJdbcV2CompatibilityStreamStateValue.kt

@@ -51,7 +51,7 @@ data class PostgresSourceJdbcV2CompatibilityStreamStateValue(
                                     cursorField,
                                     incrementalState.cursorValue!!.asText()
                                 )
-                            ) // TEMP
+                            ) // TODO: check here
                         }
                         else -> mapOf()
                     }