fix issue checking detached when git less than 2.22 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Jan 2, 2020
ericsciple
changed the title
ericsciple
changed the title
ericsciple
commented
Jan 2, 2020
| // Note, this implementation uses "rev-parse --symbolic-full-name" because the output from | ||
| // "branch --list" is more difficult when in a detached HEAD state. | ||
| const args = ['rev-parse', '--symbolic']; | ||
| // Note, this implementation uses "rev-parse --symbolic-full-name" because there is a bug |
Contributor
Author
There was a problem hiding this comment.
i ran into this bug in git 2.18 when testing. Switching to --symbolic-full-name and trimming refs/heads/ and refs/remotes/ from the output works around the issue.
ericsciple
commented
Jan 2, 2020
| return !!output.stdout.trim(); | ||
| }); | ||
| } | ||
| branchList(remote) { |
Contributor
Author
There was a problem hiding this comment.
useful script for testing:
- run: |
cd ..
Invoke-WebRequest -Uri https://github.com/git-for-windows/git/releases/download/v2.18.0.windows.1/MinGit-2.18.0-64-bit.zip -OutFile mingit.zip
mkdir mingit
Expand-Archive -LiteralPath .\mingit.zip -DestinationPath .\mingit
dir .\mingit
echo "::add-path::$PWD\mingit\cmd"
TingluoHuang
approved these changes
Jan 2, 2020
This was referenced Mar 6, 2021
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #121