Update Ktor to 3.2.1 / Koin to 4.1.0

Koin added support for Ktor 3 in version 4.1.0, but apparently also
broke Ktor 2 support in the same release. Thus, we need to update both
dependencies simultaneously.

For some reason, Ktor hasn't published ktor-server-tests for Ktor 3 even
though Ktor 3 has been out since 2024-10-10. We're not actually using
Ktor tests currently, so we can remove that dependency to allow the
upgrade to build.

Author: lberrymage

console/build.gradle.kts

@@ -55,7 +55,6 @@ dependencies {
     implementation(libs.ktor.server.resources)
     implementation(libs.logback)
     implementation(libs.postgresql)
-    testImplementation(libs.ktor.server.tests)
     testImplementation(libs.kotlin.test)
 }
 

console/src/main/kotlin/app/accrescent/parcelo/console/data/Database.kt

@@ -65,7 +65,7 @@ fun Application.configureDatabase(): DataSource {
             BaselineWhitelistedGitHubUsers,
         )
 
-        if (environment.developmentMode) {
+        if (developmentMode) {
             // Create a default superuser
             val debugUserGitHubId = (System.getenv("DEBUG_USER_GITHUB_ID")
                 ?: throw Exception("DEBUG_USER_GITHUB_ID not specified in environment")).toLong()

console/src/main/kotlin/app/accrescent/parcelo/console/routes/Drafts.kt

@@ -35,7 +35,6 @@ import io.ktor.http.content.PartData
 import io.ktor.http.content.readAllParts
 import io.ktor.http.content.streamProvider
 import io.ktor.resources.Resource
-import io.ktor.server.application.call
 import io.ktor.server.auth.authenticate
 import io.ktor.server.auth.principal
 import io.ktor.server.request.receive
@@ -105,6 +104,7 @@ fun Route.createDraftRoute() {
         var shortDescription: String? = null
         var iconData: ByteArray? = null
 
+        @Suppress("DEPRECATION_ERROR")
         val multipart = call.receiveMultipart().readAllParts()
 
         try {

console/src/main/kotlin/app/accrescent/parcelo/console/routes/Edits.kt

@@ -91,6 +91,7 @@ fun Route.createEditRoute() {
 
         var shortDescription: String? = null
 
+        @Suppress("DEPRECATION_ERROR")
         val multipart = call.receiveMultipart().readAllParts()
 
         try {

console/src/main/kotlin/app/accrescent/parcelo/console/routes/Updates.kt

@@ -110,6 +110,7 @@ fun Route.createUpdateRoute() {
 
         var apkSet: ApkSet? = null
 
+        @Suppress("DEPRECATION_ERROR")
         val multipart = call.receiveMultipart().readAllParts()
 
         try {

console/src/main/kotlin/app/accrescent/parcelo/console/routes/auth/Auth.kt

@@ -42,7 +42,7 @@ fun Application.configureAuthentication(
     githubRedirectUrl: String,
     httpClient: HttpClient = HttpClient(),
 ) {
-    val developmentMode = environment.developmentMode
+    val developmentMode = developmentMode
 
     install(Sessions) {
         cookie<Session>(if (!developmentMode) "__Host-session" else "session") {

console/src/main/kotlin/app/accrescent/parcelo/console/routes/auth/GitHub.kt

@@ -15,6 +15,7 @@ import io.ktor.client.HttpClient
 import io.ktor.http.Cookie
 import io.ktor.http.HttpMethod
 import io.ktor.http.HttpStatusCode
+import io.ktor.server.application.Application
 import io.ktor.server.application.ApplicationEnvironment
 import io.ktor.server.application.call
 import io.ktor.server.auth.AuthenticationConfig
@@ -52,7 +53,7 @@ const val COOKIE_OAUTH_STATE_LIFETIME = 60 * 60 // 1 hour
 /**
  * A helper method for getting the name of the OAuth2 state cookie name in the current mode
  */
-val ApplicationEnvironment.oauthStateCookieName
+val Application.oauthStateCookieName
     get() =
         if (!developmentMode) COOKIE_OAUTH_STATE_PROD else COOKIE_OAUTH_STATE_DEVEL
 
@@ -90,7 +91,7 @@ fun AuthenticationConfig.github(
                     // See https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-30#section-10.12
                     call.response.cookies.append(
                         Cookie(
-                            name = call.application.environment.oauthStateCookieName,
+                            name = call.application.oauthStateCookieName,
                             value = state,
                             maxAge = COOKIE_OAUTH_STATE_LIFETIME,
                             path = "/",
@@ -118,7 +119,7 @@ fun Route.githubRoutes() {
                 // Cross-site request forgery (CSRF) protection.
                 // See https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-30#section-10.12
                 val oauthCookie =
-                    call.request.cookies[call.application.environment.oauthStateCookieName]
+                    call.request.cookies[call.application.oauthStateCookieName]
                 if (oauthCookie == null) {
                     call.respond(HttpStatusCode.Forbidden)
                     return@get

console/src/test/kotlin/app/accrescent/parcelo/ApplicationTest.kt

@@ -13,10 +13,10 @@ github = "1.327"
 google-cloud = "26.63.0"
 jackson = "2.19.1"
 jobrunr = "7.5.3"
-koin = "4.0.0"
+koin = "4.1.0"
 kotlin = "2.2.0"
 ksp = "2.2.0-2.0.2"
-ktor = "2.3.12"
+ktor = "3.2.1"
 logback = "1.5.18"
 postgresql = "42.7.7"
 protobuf = "4.31.1"
@@ -48,7 +48,6 @@ ktor-server-cors = { module = "io.ktor:ktor-server-cors", version.ref = "ktor" }
 ktor-server-negotiation = { module = "io.ktor:ktor-server-content-negotiation", version.ref = "ktor" }
 ktor-server-netty = { module = "io.ktor:ktor-server-netty", version.ref = "ktor" }
 ktor-server-resources = { module = "io.ktor:ktor-server-resources", version.ref = "ktor" }
-ktor-server-tests = { module = "io.ktor:ktor-server-tests", version.ref = "ktor" }
 logback = { module = "ch.qos.logback:logback-classic", version.ref = "logback" }
 postgresql = { module = "org.postgresql:postgresql", version.ref = "postgresql" }
 protobuf = { module = "com.google.protobuf:protobuf-java", version.ref = "protobuf" }