docs: Add how-to for integrating with vw-estimators #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataymano
approved these changes
Feb 13, 2023
ataymano
reviewed
Feb 13, 2023
| "\n", | ||
| "with open(\"example_cb.txt\") as dataset_file:\n", | ||
| " with vw.TextFormatReader(workspace, dataset_file) as reader:\n", | ||
| " for example in reader:\n", |
Member
There was a problem hiding this comment.
"example" here vs "examples" in the next line (extract_label signature) is a bit confusing
Member
Author
There was a problem hiding this comment.
True. Perhaps I should rename to event?
ataymano
reviewed
Feb 14, 2023
| " logged_action_0_based, logged_cost, logged_prob = logged_label\n", | ||
| "\n", | ||
| " # 4. Get the probability of choosing the logged action according to the target policy\n", | ||
| " prediction_prob = next(x for i, x in pmf if i == logged_action_0_based)\n", |
Member
There was a problem hiding this comment.
[nit] dict(pmf)[logged_action_0_based] (not sure which one is more readable)
Member
Author
There was a problem hiding this comment.
Oh interesting, I didn't know you could init a dictionary like that
ataymano
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #48