Restructure CMakeLists.txt to be suitable for CPM.cmake #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include tests and installation logic when for example CMake Package Manager (CPM.cmake) is used to add the project as a subdirectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for making this library!
I'm using CMake Package Manager (CPM.cmake) to add libraries like this one to CMake projects. CPM.cmake makes adding external libraries easy when the library has a CMake build system that works
well when added as a subdirectory.
This pull request makes a minor change to the CMake build system so that tests and installation logic are not included when the project is not the root project (i.e. added using
add_subdirectory). The advantage of doing this is that projects using this library will not accidentally build and run tests or install files defined by this project.I'm open to feedback if this doesn't work well with existing CMake workflows.