Deny PKG installation without RAP #17828
Open
+142
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think the message only creates more questions than answers. |
Megamouse
reviewed
Dec 6, 2025
|
|
||
| if (std::count(missing_licenses_short.begin(), missing_licenses_short.end(), '\n') < 5) | ||
| { | ||
| missing_licenses_short += std::string_view(filepath).substr(filepath.find_last_of(fs::delim) + 1); |
Contributor
There was a problem hiding this comment.
What's the purpose of casting to stringview here?
Megamouse
reviewed
Dec 6, 2025
|
|
||
| if (!missing_licenses.empty()) | ||
| { | ||
| gui_log.fatal("Failed to locate the game license file(s):\n%s" |
Megamouse
reviewed
Dec 6, 2025
| } | ||
| else | ||
| { | ||
| pkg_log.notice("PKG need not a license file."); |
Megamouse
reviewed
Dec 6, 2025
| return {}; | ||
| } | ||
|
|
||
| if (npd->license == 1) // Network license. |
Megamouse
reviewed
Dec 6, 2025
| } | ||
|
|
||
| // Check the ELF file class (32 or 64 bit). | ||
| const bool isElf32 = IsSelfElf32(elf_or_self); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log error is remained, and if you install multiple PKGs it would only print the missing RAP file path.
Relates to #17805