Fix fireball mobgriefing override not working

[madebytwentyfive]

The existing does so if the game rule this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING) is true, then the whole condition is true, which is why blocks still get destroyed even when the config is set to false.

The fix is to check if the source is a fireball, it will check the purpur config in this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING, this.purpurConfig.fireballsMobGriefingOverride).

Else it will use the default one this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING).

This is tested with every value and it works.

Fixes #1722

[BillyGalbreath]

This doesn't change anything. They're the same thing. nvm. see below

[madebytwentyfive]

Mind if you explain ?

[madebytwentyfive]

- case MOB -> (source instanceof net.minecraft.world.entity.projectile.LargeFireball && this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING, this.purpurConfig.fireballsMobGriefingOverride)) || this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING) // Purpur - Add mobGriefing override to everything affected
+ case MOB -> ((source instanceof net.minecraft.world.entity.projectile.LargeFireball) ? this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING, this.purpurConfig.fireballsMobGriefingOverride) : this.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING)) // Purpur - Add mobGriefing override to everything affected

• Let's take the gamerule set to true and in config it's set to false. source is also a LargeFireball:

1. Old version:

• (true && false) || true -> true, means it can grief (Which is not correct, because the override is false).

2. New version:

• true ? false : true -> false, means it can't grief blocks which respects the config.

Note that getBoolean(key, value) doesn't override the gamerule.
Looking at the code, it just checks if the value is not null: If it's not null, it will return the value, else it will return the key's value.

[BillyGalbreath]

Mind if you explain ?

my bad. as i was writing it out to explain myself, i caught the subtle difference lol

don't mind me ^_^

[granny]

Thank you for the PR!